Re: [PR] doris illegal label fix [doris-flink-connector]

2024-07-23 Thread via GitHub
JNSimba closed pull request #421: doris illegal label fix URL: https://github.com/apache/doris-flink-connector/pull/421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] doris illegal label fix [doris-flink-connector]

2024-07-23 Thread via GitHub
JNSimba commented on PR #421: URL: https://github.com/apache/doris-flink-connector/pull/421#issuecomment-2246730205 I agree with @DongLiang-0 suggestion. It would be better to modify it on Doris side, because the client is not only Flink. Close this first, and you can open it at any time

Re: [PR] doris illegal label fix [doris-flink-connector]

2024-07-10 Thread via GitHub
DongLiang-0 commented on PR #421: URL: https://github.com/apache/doris-flink-connector/pull/421#issuecomment-2221845700 > > @DongLiang-0 Thank you for your reply! Do you mean that the SQL `CLEAN LABEL label1 FROM db1;`restriction on label naming, should be solved in Doris project? Am I

Re: [PR] doris illegal label fix [doris-flink-connector]

2024-07-10 Thread via GitHub
monologuist commented on PR #421: URL: https://github.com/apache/doris-flink-connector/pull/421#issuecomment-2221815330 > Thanks for trying to resolve this issue. > > I looked at doris's use of this section and found that it is `CLEAN LABEL [label] FROM db;` This SQL has some syntax

Re: [PR] doris illegal label fix [doris-flink-connector]

2024-07-10 Thread via GitHub
DongLiang-0 commented on PR #421: URL: https://github.com/apache/doris-flink-connector/pull/421#issuecomment-2220186454 Thanks for trying to resolve this issue. I looked at doris's use of this section and found that it is `CLEAN LABEL [label] FROM db;` This SQL has some syntax proble

Re: [PR] doris illegal label fix [doris-flink-connector]

2024-07-10 Thread via GitHub
monologuist commented on PR #421: URL: https://github.com/apache/doris-flink-connector/pull/421#issuecomment-2219728231 @JNSimba @CalvinKirs Hi, can you review my code? I think this is a problem and needs to be fixed -- This is an automated message from the Apache Git Service. To respond

[PR] doris illegal label fix [doris-flink-connector]

2024-07-09 Thread via GitHub
monologuist opened a new pull request, #421: URL: https://github.com/apache/doris-flink-connector/pull/421 # Proposed changes Issue Number: close #420 ## Problem Summary: Describe the overview of changes. Replace the "-" in label with "_" to ensure the generation of a leg