Re: [PR] change ControlThrowable from NonFatal to Fatal [doris-spark-connector]

2025-03-31 Thread via GitHub
zhaorongsheng commented on PR #301: URL: https://github.com/apache/doris-spark-connector/pull/301#issuecomment-2765666990 It's a supplementary PR of #206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] change ControlThrowable from NonFatal to Fatal [doris-spark-connector]

2025-03-31 Thread via GitHub
zhaorongsheng commented on PR #301: URL: https://github.com/apache/doris-spark-connector/pull/301#issuecomment-2765654520 > Here we should just check whether the status of commit and abort is success? Spark class `ListenerBus`( line 127) will not throw exception when it check the e

Re: [PR] change ControlThrowable from NonFatal to Fatal [doris-spark-connector]

2025-03-31 Thread via GitHub
JNSimba commented on PR #301: URL: https://github.com/apache/doris-spark-connector/pull/301#issuecomment-2765640857 Here we should just check whether the status of commit and abort is success? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[PR] change ControlThrowable from NonFatal to Fatal [doris-spark-connector]

2025-03-31 Thread via GitHub
zhaorongsheng opened a new pull request, #301: URL: https://github.com/apache/doris-spark-connector/pull/301 # Proposed changes Issue Number: close #205 ## Problem Summary: Throw exception when commit unsuccessfully. And change the exception from NonFatal to Fatal excep