yiguolei merged PR #45410:
URL: https://github.com/apache/doris/pull/45410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apa
yiguolei commented on code in PR #45410:
URL: https://github.com/apache/doris/pull/45410#discussion_r1886003119
##
be/src/vec/common/columns_hashing.h:
##
@@ -152,8 +152,12 @@ struct HashMethodSingleLowNullableColumn : public
SingleColumnMethod {
template
ALWAYS_IN
yiguolei commented on code in PR #45410:
URL: https://github.com/apache/doris/pull/45410#discussion_r1886002786
##
be/src/vec/core/block.cpp:
##
@@ -734,7 +734,8 @@ void Block::clear_column_data(int64_t column_size) noexcept
{
}
for (auto& d : data) {
if (d.c
yiguolei commented on code in PR #45410:
URL: https://github.com/apache/doris/pull/45410#discussion_r1886001321
##
be/src/pipeline/exec/partitioned_hash_join_probe_operator.h:
##
@@ -81,7 +81,6 @@ class PartitionedHashJoinProbeLocalState final
std::vector _probe_spilling_st
yiguolei commented on code in PR #45410:
URL: https://github.com/apache/doris/pull/45410#discussion_r1886000899
##
be/src/pipeline/exec/partitioned_hash_join_probe_operator.cpp:
##
@@ -407,20 +407,21 @@ std::string
PartitionedHashJoinProbeLocalState::debug_string(int indentatio
yiguolei commented on code in PR #45410:
URL: https://github.com/apache/doris/pull/45410#discussion_r1886000410
##
be/src/pipeline/exec/partitioned_aggregation_source_operator.cpp:
##
@@ -257,7 +260,9 @@ Status
PartitionedAggLocalState::recover_blocks_from_disk(RuntimeState* st
Thearas commented on PR #45410:
URL: https://github.com/apache/doris/pull/45410#issuecomment-2541117512
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
github-actions[bot] commented on code in PR #45410:
URL: https://github.com/apache/doris/pull/45410#discussion_r1883723462
##
be/src/common/config.cpp:
##
@@ -16,6 +16,7 @@
// under the License.
#include
Review Comment:
warning: 'fmt/core.h' file not found [clang-diagno
mrhhsg opened a new pull request, #45410:
URL: https://github.com/apache/doris/pull/45410
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test
