Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2025-02-24 Thread via GitHub
Mryange closed pull request #42854: [refine](function) Remove mutable variables in the function URL: https://github.com/apache/doris/pull/42854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-11-06 Thread via GitHub
doris-robot commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2461236353 TeamCity be ut coverage result: Function Coverage: 37.87% (9847/26000) Line Coverage: 29.03% (81876/282034) Region Coverage: 28.26% (42179/149240) Branch Coverage: 24.8

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-11-06 Thread via GitHub
Mryange commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2461159208 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-11-05 Thread via GitHub
doris-robot commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2458674638 TeamCity be ut coverage result: Function Coverage: 37.84% (9833/25984) Line Coverage: 29.03% (81811/281857) Region Coverage: 28.26% (42148/149159) Branch Coverage: 24.8

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-11-05 Thread via GitHub
Mryange commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2458577370 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2454111636 TeamCity be ut coverage result: Function Coverage: 37.80% (9819/25976) Line Coverage: 28.97% (81650/281817) Region Coverage: 28.22% (42100/149189) Branch Coverage: 24.8

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-11-03 Thread via GitHub
Mryange commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2453942289 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2451667361 TeamCity be ut coverage result: Function Coverage: 37.80% (9818/25973) Line Coverage: 28.99% (81626/281549) Region Coverage: 28.26% (42137/149121) Branch Coverage: 24.8

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-11-01 Thread via GitHub
github-actions[bot] commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2451548074 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-11-01 Thread via GitHub
Mryange commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2451541904 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-30 Thread via GitHub
doris-robot commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2446196491 TeamCity be ut coverage result: Function Coverage: 37.95% (9845/25945) Line Coverage: 29.22% (82002/280628) Region Coverage: 28.56% (42287/148039) Branch Coverage: 25.0

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-30 Thread via GitHub
Mryange commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2446004198 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2446009544 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
doris-robot commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2445535084 TeamCity be ut coverage result: Function Coverage: 37.68% (9773/25934) Line Coverage: 28.76% (80707/280614) Region Coverage: 28.19% (41731/148032) Branch Coverage: 24.7

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2445513795 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
Mryange commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2445509463 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
Mryange commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2444097741 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2444526715 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
Mryange commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2444513629 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
doris-robot commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2444251414 TeamCity be ut coverage result: Function Coverage: 37.68% (9771/25934) Line Coverage: 28.74% (80656/280614) Region Coverage: 28.19% (41725/148032) Branch Coverage: 24.7

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2444107858 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
Mryange commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2443603521 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2443613659 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
doris-robot commented on PR #42854: URL: https://github.com/apache/doris/pull/42854#issuecomment-2443603236 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [refine](function) Remove mutable variables in the function [doris]

2024-10-29 Thread via GitHub
Mryange opened a new pull request, #42854: URL: https://github.com/apache/doris/pull/42854 ## Proposed changes Remove mutable variables in the function. If state is needed within the function, it should be placed in FunctionContext. -- This is an automated