Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-17 Thread via GitHub
BiteThet merged PR #43939: URL: https://github.com/apache/doris/pull/43939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-15 Thread via GitHub
github-actions[bot] commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2480435968 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-15 Thread via GitHub
github-actions[bot] commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2480436085 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-15 Thread via GitHub
HappenLee commented on code in PR #43939: URL: https://github.com/apache/doris/pull/43939#discussion_r1844918438 ## be/src/vec/columns/column.h: ## @@ -503,13 +503,17 @@ class IColumn : public COW { /** Split column to smaller columns. Each value goes to column index, se

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-15 Thread via GitHub
doris-robot commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2478252290 TeamCity be ut coverage result: Function Coverage: 38.04% (9902/26033) Line Coverage: 29.19% (82738/283415) Region Coverage: 28.31% (42486/150065) Branch Coverage: 24.8

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-14 Thread via GitHub
github-actions[bot] commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2478098040 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-14 Thread via GitHub
Mryange commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2478091972 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-14 Thread via GitHub
Mryange commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2476282833 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-14 Thread via GitHub
doris-robot commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2475702414 TeamCity be ut coverage result: Function Coverage: 37.97% (9886/26039) Line Coverage: 29.14% (82627/283526) Region Coverage: 28.26% (42456/150223) Branch Coverage: 24.8

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-13 Thread via GitHub
Mryange commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2475516833 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-13 Thread via GitHub
github-actions[bot] commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2475522539 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-13 Thread via GitHub
github-actions[bot] commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2475517590 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-13 Thread via GitHub
doris-robot commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2475511489 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+proce

Re: [PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-13 Thread via GitHub
Mryange commented on PR #43939: URL: https://github.com/apache/doris/pull/43939#issuecomment-2475511593 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] [refine](column) refine append_data_by_selector code [doris]

2024-11-13 Thread via GitHub
Mryange opened a new pull request, #43939: URL: https://github.com/apache/doris/pull/43939 ### What problem does this PR solve? ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps bel