zclllyybb commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1804216387
##
be/src/vec/functions/array/function_array_contains_all.cpp:
##
@@ -37,8 +37,6 @@ class FunctionArrayContainsAll : public IFunction {
String get_name() const
zclllyybb commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1802330142
##
be/src/vec/functions/array/function_array_range.cpp:
##
@@ -146,14 +144,6 @@ struct RangeImplUtil {
for (int i = 0; i < 3; ++i) {
argument_co
zclllyybb commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1802330142
##
be/src/vec/functions/array/function_array_range.cpp:
##
@@ -146,14 +144,6 @@ struct RangeImplUtil {
for (int i = 0; i < 3; ++i) {
argument_co
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801495314
##
be/src/vec/functions/array/function_array_contains_all.cpp:
##
@@ -37,8 +37,6 @@ class FunctionArrayContainsAll : public IFunction {
String get_name() const ov
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801495314
##
be/src/vec/functions/array/function_array_contains_all.cpp:
##
@@ -37,8 +37,6 @@ class FunctionArrayContainsAll : public IFunction {
String get_name() const ov
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801491554
##
be/src/vec/functions/array/function_array_range.cpp:
##
@@ -146,14 +144,6 @@ struct RangeImplUtil {
for (int i = 0; i < 3; ++i) {
argument_colum
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801488619
##
be/src/vec/functions/array/function_array_range.cpp:
##
@@ -146,14 +144,6 @@ struct RangeImplUtil {
for (int i = 0; i < 3; ++i) {
argument_colum
zhiqiang- commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801352593
##
be/src/vec/functions/array/function_array_contains_all.cpp:
##
@@ -37,8 +37,6 @@ class FunctionArrayContainsAll : public IFunction {
String get_name() c
zhiqiang- commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801350137
##
be/src/vec/functions/array/function_array_range.cpp:
##
@@ -146,14 +144,6 @@ struct RangeImplUtil {
for (int i = 0; i < 3; ++i) {
argumen
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801078402
##
be/src/vec/functions/array/function_array_range.cpp:
##
@@ -146,14 +144,6 @@ struct RangeImplUtil {
for (int i = 0; i < 3; ++i) {
argument_colum
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801075968
##
be/src/vec/functions/array/function_array_contains_all.cpp:
##
@@ -37,8 +37,6 @@ class FunctionArrayContainsAll : public IFunction {
String get_name() const ov
zhiqiang- commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801019820
##
be/src/vec/functions/array/function_array_range.cpp:
##
@@ -146,14 +144,6 @@ struct RangeImplUtil {
for (int i = 0; i < 3; ++i) {
argumen
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2410668260
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2409047482
ClickBench: Total hot run time: 32.12 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2409045712
TPC-DS: Total hot run time: 191413 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2409043422
TeamCity be ut coverage result:
Function Coverage: 37.41% (9671/25848)
Line Coverage: 28.64% (80139/279845)
Region Coverage: 28.08% (41455/147637)
Branch Coverage: 24.6
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2409042122
TPC-H: Total hot run time: 41009 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
Yoruet commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2409013184
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408942521
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408932465
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408932620
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1798171676
##
.gitignore:
##
@@ -143,3 +143,4 @@ docker/runtime/be/resource/apache-doris/
compile_commands.json
.github
+core
Review Comment:
don't commit this too. or j
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408877691
ClickBench: Total hot run time: 32.29 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408875719
TPC-DS: Total hot run time: 191215 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408871070
TPC-H: Total hot run time: 40591 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408870044
TeamCity be ut coverage result:
Function Coverage: 37.41% (9671/25848)
Line Coverage: 28.64% (80141/279843)
Region Coverage: 28.08% (41457/147638)
Branch Coverage: 24.6
Yoruet commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408857720
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408856438
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408850782
ClickBench: Total hot run time: 32.33 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408849534
TPC-DS: Total hot run time: 191712 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408846557
TPC-H: Total hot run time: 40676 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408838640
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Yoruet commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408837991
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408836270
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Yoruet commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408835504
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408799405
ClickBench: Total hot run time: 32.54 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408797379
TPC-DS: Total hot run time: 191683 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408794886
TPC-H: Total hot run time: 40586 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408787759
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Yoruet commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408786992
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Yoruet commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1797943579
##
be/src/vec/functions/function_bitmap.cpp:
##
@@ -506,10 +504,10 @@ class FunctionBitmapCount : public IFunction {
auto& null_map = data_null_map->get_data();
zclllyybb commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1797730922
##
be/src/vec/functions/function_bitmap.cpp:
##
@@ -506,10 +504,10 @@ class FunctionBitmapCount : public IFunction {
auto& null_map = data_null_map->get_data
zclllyybb commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1797730959
##
env.sh:
##
@@ -19,6 +19,7 @@
# check DORIS_HOME
export LC_ALL=C
+export CUSTOM_NPM_REGISTRY="https://mirrors.huaweicloud.com/repository/npm/";
Review Comment:
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408574291
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408573543
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Yoruet commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408572804
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Yoruet commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408572149
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408531190
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408529187
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2408519534
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1797603709
##
be/src/vec/functions/function_timestamp.cpp:
##
@@ -115,12 +115,9 @@ struct StrToDate {
ColumnPtr argument_columns[2] = {
col_const[0] ?
zclllyybb commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1797603443
##
be/src/vec/functions/function_conv.cpp:
##
@@ -72,7 +72,7 @@ class FunctionConv : public IFunction {
return get_variadic_argument_types_impl().size();
github-actions[bot] commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2407859810
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
doris-robot commented on PR #41739:
URL: https://github.com/apache/doris/pull/41739#issuecomment-2407852577
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
Yoruet opened a new pull request, #41739:
URL: https://github.com/apache/doris/pull/41739
## Proposed changes
Issue Number: close #xxx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
github-actions[bot] commented on PR #41738:
URL: https://github.com/apache/doris/pull/41738#issuecomment-2407820586
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Yoruet closed pull request #41738: [refactor]Delete useless code
check_set_nullable()
URL: https://github.com/apache/doris/pull/41738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
Yoruet opened a new pull request, #41738:
URL: https://github.com/apache/doris/pull/41738
## Proposed changes
Issue Number: close #xxx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
doris-robot commented on PR #41738:
URL: https://github.com/apache/doris/pull/41738#issuecomment-2407813110
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
59 matches
Mail list logo
