Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-13 Thread via GitHub
zhiqiang- commented on code in PR #34370: URL: https://github.com/apache/doris/pull/34370#discussion_r1599375169 ## fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java: ## @@ -1466,23 +1469,27 @@ public boolean shouldCancel(List currentBackends) { // fragment

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-10 Thread via GitHub
yiguolei merged PR #34370: URL: https://github.com/apache/doris/pull/34370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-10 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2105590047 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-10 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2105590039 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-10 Thread via GitHub
doris-robot commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2105505144 TeamCity be ut coverage result: Function Coverage: 35.68% (8981/25172) Line Coverage: 27.34% (74251/271553) Region Coverage: 26.58% (38385/144411) Branch Coverage: 23.4

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-10 Thread via GitHub
doris-robot commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2105503085 TPC-DS: Total hot run time: 187853 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-10 Thread via GitHub
doris-robot commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2105500054 TPC-H: Total hot run time: 41723 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-10 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2105443182 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-10 Thread via GitHub
yiguolei commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2105440068 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
doris-robot commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2103963067 TeamCity be ut coverage result: Function Coverage: 35.68% (8980/25170) Line Coverage: 27.33% (74181/271473) Region Coverage: 26.56% (38341/144357) Branch Coverage: 23.3

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2103878423 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
yiguolei commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2103872001 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2103814833 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
yiguolei commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2103807015 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
doris-robot commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2102764251 TeamCity be ut coverage result: Function Coverage: 35.69% (8982/25170) Line Coverage: 27.34% (74204/271434) Region Coverage: 26.57% (38363/144360) Branch Coverage: 23.3

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2102622535 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
yiguolei commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2102611884 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
doris-robot commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2102250669 TeamCity be ut coverage result: Function Coverage: 35.69% (8983/25170) Line Coverage: 27.34% (74214/271444) Region Coverage: 26.58% (38379/144370) Branch Coverage: 23.3

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
doris-robot commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2102227150 TPC-DS: Total hot run time: 186221 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
doris-robot commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2102208754 TPC-H: Total hot run time: 40781 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2102111633 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-09 Thread via GitHub
yiguolei commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2102102781 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-08 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2101987422 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-08 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2100358535 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-08 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2100348496 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-08 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2100339564 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2099857040 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2099842844 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2099829062 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2099722861 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-04-30 Thread via GitHub
doris-robot commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2086652456 TPC-DS: Total hot run time: 185546 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-04-30 Thread via GitHub
doris-robot commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2086585347 TPC-H: Total hot run time: 41574 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-04-30 Thread via GitHub
yiguolei commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2086098778 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-04-30 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2085763750 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-04-30 Thread via GitHub
github-actions[bot] commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2085745745 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-04-30 Thread via GitHub
doris-robot commented on PR #34370: URL: https://github.com/apache/doris/pull/34370#issuecomment-2085731666 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [refactor](fe status) unify fe status code and remove cancel reason [doris]

2024-04-30 Thread via GitHub
yiguolei opened a new pull request, #34370: URL: https://github.com/apache/doris/pull/34370 ## Proposed changes Currently, we could not get real cancel reason because the status is very mess. In this PR I do following: 1. add new method in status.java, like be code. user could use