Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-29 Thread via GitHub
github-actions[bot] commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2564735730 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-29 Thread via GitHub
yiguolei merged PR #46034: URL: https://github.com/apache/doris/pull/46034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-29 Thread via GitHub
github-actions[bot] commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2564734791 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-28 Thread via GitHub
doris-robot commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2564427952 ClickBench: Total hot run time: 31.43 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-28 Thread via GitHub
doris-robot commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2564426907 TPC-DS: Total hot run time: 197826 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-28 Thread via GitHub
doris-robot commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2564419809 TPC-H: Total hot run time: 32976 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-28 Thread via GitHub
doris-robot commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2564411519 TeamCity be ut coverage result: Function Coverage: 38.91% (10122/26016) Line Coverage: 29.90% (85545/286093) Region Coverage: 29.03% (43726/150609) Branch Coverage: 25.

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-28 Thread via GitHub
yiguolei commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2564398090 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-28 Thread via GitHub
yiguolei commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2564367541 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-28 Thread via GitHub
yiguolei commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2564348027 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-27 Thread via GitHub
yiguolei commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2564204036 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-27 Thread via GitHub
yiguolei commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2563867753 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-27 Thread via GitHub
yiguolei commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2563790769 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-27 Thread via GitHub
doris-robot commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2563546247 ClickBench: Total hot run time: 31.12 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-27 Thread via GitHub
doris-robot commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2563540988 TPC-DS: Total hot run time: 197069 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-27 Thread via GitHub
doris-robot commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2563529589 TPC-H: Total hot run time: 33124 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-27 Thread via GitHub
yiguolei commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2563487048 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-27 Thread via GitHub
yiguolei commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2563435548 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2562957325 ClickBench: Total hot run time: 32.06 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2562953243 TPC-DS: Total hot run time: 197304 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2562945173 TPC-H: Total hot run time: 32766 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-26 Thread via GitHub
yiguolei commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2562886597 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-26 Thread via GitHub
hello-stephen commented on PR #46034: URL: https://github.com/apache/doris/pull/46034#issuecomment-2562376824 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro

[PR] [refactor](execenv) remove shared ptr from exec env [doris]

2024-12-26 Thread via GitHub
yiguolei opened a new pull request, #46034: URL: https://github.com/apache/doris/pull/46034 ### What problem does this PR solve? ExecEnv should be the last object to deconstructed, so that it should not own any shared ptr. If it own any shared ptr, then we could not make sure the dec