Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-13 Thread via GitHub
github-actions[bot] commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2472839769 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-13 Thread via GitHub
gavinchou merged PR #41167: URL: https://github.com/apache/doris/pull/41167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-13 Thread via GitHub
github-actions[bot] commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2472839280 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-13 Thread via GitHub
github-actions[bot] commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2472845084 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-13 Thread via GitHub
github-actions[bot] commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2472839338 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-13 Thread via GitHub
w41ter commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2472838275 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-10 Thread via GitHub
github-actions[bot] commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2467260074 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-10 Thread via GitHub
github-actions[bot] commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2467179993 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-10 Thread via GitHub
w41ter commented on code in PR #41167: URL: https://github.com/apache/doris/pull/41167#discussion_r1835904442 ## fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java: ## @@ -1576,7 +1576,9 @@ public void logTableRename(TableInfo tableInfo) { } public void l

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-07 Thread via GitHub
xiaoming12306 commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2463672091 @w41ter please help to review code, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-07 Thread via GitHub
xiaoming12306 commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2463667629 @w41ter please help to review code, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-07 Thread via GitHub
xiaoming12306 commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-246359 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-07 Thread via GitHub
xiaoming12306 commented on code in PR #41167: URL: https://github.com/apache/doris/pull/41167#discussion_r1833627785 ## gensrc/thrift/FrontendService.thrift: ## @@ -1185,6 +1185,7 @@ enum TBinlogType { TRUNCATE_TABLE = 13, RENAME_TABLE = 14, RENAME_COLUMN = 15, + MODIF

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-07 Thread via GitHub
github-actions[bot] commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2463639349 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-11-07 Thread via GitHub
smallx commented on code in PR #41167: URL: https://github.com/apache/doris/pull/41167#discussion_r1832249471 ## gensrc/thrift/FrontendService.thrift: ## @@ -1185,6 +1185,7 @@ enum TBinlogType { TRUNCATE_TABLE = 13, RENAME_TABLE = 14, RENAME_COLUMN = 15, + MODIFY_VIEW_

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-09-24 Thread via GitHub
xiaoming12306 commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2370733105 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-09-23 Thread via GitHub
doris-robot commented on PR #41167: URL: https://github.com/apache/doris/pull/41167#issuecomment-2368043015 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [opt] (binlog) Support Modify ViewDef binlog [doris]

2024-09-23 Thread via GitHub
xiaoming12306 opened a new pull request, #41167: URL: https://github.com/apache/doris/pull/41167 [opt] (binlog) Support Modify ViewDef binlog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go