ByteYue commented on code in PR #35396:
URL: https://github.com/apache/doris/pull/35396#discussion_r1650948661
##
be/src/io/fs/s3_file_reader.cpp:
##
@@ -113,23 +120,85 @@ Status S3FileReader::read_at_impl(size_t offset, Slice
result, size_t* bytes_rea
if (!client) {
morningman commented on code in PR #35396:
URL: https://github.com/apache/doris/pull/35396#discussion_r1650677371
##
be/src/io/fs/s3_file_reader.cpp:
##
@@ -44,13 +45,18 @@ bvar::Adder
s3_file_reader_read_counter("s3_file_reader", "read_at");
bvar::Adder s3_file_reader_total("
doris-robot commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2185729753
ClickBench: Total hot run time: 31.11 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2185722191
TPC-DS: Total hot run time: 175217 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2185707967
TPC-H: Total hot run time: 39925 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2185607170
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
morningman commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2185602325
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
ByteYue commented on code in PR #35396:
URL: https://github.com/apache/doris/pull/35396#discussion_r1623719888
##
be/src/io/fs/s3_file_reader.cpp:
##
@@ -44,13 +45,18 @@ bvar::Adder
s3_file_reader_read_counter("s3_file_reader", "read_at");
bvar::Adder s3_file_reader_total("s3_
AshinGau commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2138829921
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
github-actions[bot] commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2138661374
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2138661340
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2135717934
TeamCity be ut coverage result:
Function Coverage: 35.78% (9011/25185)
Line Coverage: 27.39% (74588/272333)
Region Coverage: 26.61% (38600/145047)
Branch Coverage: 23.4
doris-robot commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2135712099
ClickBench: Total hot run time: 30.55 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2135703170
TPC-DS: Total hot run time: 169215 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2135684204
TPC-H: Total hot run time: 41184 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2135482374
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
morningman commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2135475376
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
morningman merged PR #35397:
URL: https://github.com/apache/doris/pull/35397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.a
github-actions[bot] commented on PR #35397:
URL: https://github.com/apache/doris/pull/35397#issuecomment-2134675055
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
gavinchou commented on PR #35397:
URL: https://github.com/apache/doris/pull/35397#issuecomment-2134673297
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
github-actions[bot] commented on PR #35397:
URL: https://github.com/apache/doris/pull/35397#issuecomment-2134612476
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #35397:
URL: https://github.com/apache/doris/pull/35397#issuecomment-2134601584
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #35397:
URL: https://github.com/apache/doris/pull/35397#issuecomment-2133795692
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #35397:
URL: https://github.com/apache/doris/pull/35397#issuecomment-2133783013
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #35397:
URL: https://github.com/apache/doris/pull/35397#issuecomment-2132703700
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #35397:
URL: https://github.com/apache/doris/pull/35397#issuecomment-2132044278
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
doris-robot commented on PR #35397:
URL: https://github.com/apache/doris/pull/35397#issuecomment-2132043179
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
morningman opened a new pull request, #35397:
URL: https://github.com/apache/doris/pull/35397
bp #35396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
github-actions[bot] commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2132004448
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
doris-robot commented on PR #35396:
URL: https://github.com/apache/doris/pull/35396#issuecomment-2131994856
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
morningman opened a new pull request, #35396:
URL: https://github.com/apache/doris/pull/35396
## Proposed changes
Sometime the s3 sdk will return error like:
```
QpsLimitExceeded Unable to parse ExceptionName: QpsLimitExceeded Message:
Please reduce your request rate. code=429 t
31 matches
Mail list logo
