Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-05 Thread via GitHub
yiguolei commented on code in PR #49777: URL: https://github.com/apache/doris/pull/49777#discussion_r2026641644 ## be/src/runtime_filter/runtime_filter_mgr.cpp: ## @@ -72,13 +72,14 @@ std::vector> RuntimeFilterMgr::get_consum Status RuntimeFilterMgr::register_consumer_filter

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-05 Thread via GitHub
doris-robot commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2772981439 ClickBench: Total hot run time: 31.05 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2774949988 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-05 Thread via GitHub
zhiqiang- commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2772747714 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-05 Thread via GitHub
yiguolei commented on code in PR #49777: URL: https://github.com/apache/doris/pull/49777#discussion_r2026654926 ## be/src/runtime_filter/runtime_filter_consumer.h: ## @@ -40,9 +42,10 @@ class RuntimeFilterConsumer : public RuntimeFilter { static Status create(RuntimeFilte

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-05 Thread via GitHub
zhiqiang- commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2774532560 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-04 Thread via GitHub
zhiqiang- opened a new pull request, #49777: URL: https://github.com/apache/doris/pull/49777 ### What problem does this PR solve? Seperated `RuntimeFilterInfo` from `RuntimeFilterConsumerHelper`. `RuntimeFilterInfo` is a Counter instead of a child runtime profile, so that it co

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-04 Thread via GitHub
doris-robot commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2779225197 TeamCity cloud ut coverage result: Function Coverage: 83.07% (1089/1311) Line Coverage: 66.06% (18158/27488) Region Coverage: 65.49% (8944/13657) Branch Coverage: 55.33

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-04 Thread via GitHub
zhiqiang- commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2779186986 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-03 Thread via GitHub
zhiqiang- commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2774226904 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-03 Thread via GitHub
yiguolei commented on code in PR #49777: URL: https://github.com/apache/doris/pull/49777#discussion_r2026644045 ## be/src/runtime_filter/runtime_filter_consumer_helper.cpp: ## @@ -28,28 +28,33 @@ RuntimeFilterConsumerHelper::RuntimeFilterConsumerHelper( : _node_id(_node

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-03 Thread via GitHub
hello-stephen commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2774876563 # BE UT Coverage Report Increment line coverage `93.33% (28/30)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/fb08365643111cf30379bf422b86013d

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-02 Thread via GitHub
doris-robot commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2774627036 ClickBench: Total hot run time: 31.57 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-02 Thread via GitHub
doris-robot commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2774618243 TPC-DS: Total hot run time: 186708 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-02 Thread via GitHub
doris-robot commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2774598946 TPC-H: Total hot run time: 34257 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-02 Thread via GitHub
doris-robot commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2774341908 ClickBench: Total hot run time: 31.26 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-02 Thread via GitHub
doris-robot commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2774330208 TPC-DS: Total hot run time: 193632 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-02 Thread via GitHub
doris-robot commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2774292561 TPC-H: Total hot run time: 33909 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-02 Thread via GitHub
Thearas commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2772743769 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-02 Thread via GitHub
doris-robot commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2772966698 TPC-DS: Total hot run time: 185144 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](profile) Optimization of RuntimeFilter profile [doris]

2025-04-02 Thread via GitHub
doris-robot commented on PR #49777: URL: https://github.com/apache/doris/pull/49777#issuecomment-2772930021 TPC-H: Total hot run time: 34133 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100