Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-16 Thread via GitHub
morrySnow merged PR #45310: URL: https://github.com/apache/doris/pull/45310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-13 Thread via GitHub
yujun777 commented on code in PR #45310: URL: https://github.com/apache/doris/pull/45310#discussion_r1883686643 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/RangeInference.java: ## @@ -461,6 +475,9 @@ public boolean isAnd() { @Override

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-13 Thread via GitHub
yujun777 commented on code in PR #45310: URL: https://github.com/apache/doris/pull/45310#discussion_r1883686340 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/AddMinMax.java: ## @@ -326,7 +326,10 @@ private Map getExprMinMaxValues(UnknownValue value

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-13 Thread via GitHub
morrySnow commented on code in PR #45310: URL: https://github.com/apache/doris/pull/45310#discussion_r1883674353 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/AddMinMax.java: ## @@ -326,7 +326,10 @@ private Map getExprMinMaxValues(UnknownValue valu

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-13 Thread via GitHub
github-actions[bot] commented on PR #45310: URL: https://github.com/apache/doris/pull/45310#issuecomment-2540905906 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-12 Thread via GitHub
yujun777 commented on code in PR #45310: URL: https://github.com/apache/doris/pull/45310#discussion_r1883392544 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/RangeInference.java: ## @@ -130,10 +132,22 @@ private ValueDesc simplify(ExpressionRewriteC

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-12 Thread via GitHub
yujun777 commented on code in PR #45310: URL: https://github.com/apache/doris/pull/45310#discussion_r1883406908 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/RangeInference.java: ## @@ -461,6 +475,9 @@ public boolean isAnd() { @Override

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-12 Thread via GitHub
yujun777 commented on code in PR #45310: URL: https://github.com/apache/doris/pull/45310#discussion_r1883403621 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/AddMinMax.java: ## @@ -326,7 +326,10 @@ private Map getExprMinMaxValues(UnknownValue value

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-12 Thread via GitHub
yujun777 commented on code in PR #45310: URL: https://github.com/apache/doris/pull/45310#discussion_r1883395727 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/RangeInference.java: ## @@ -469,6 +486,9 @@ public ValueDesc union(ValueDesc other) {

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-12 Thread via GitHub
yujun777 commented on PR #45310: URL: https://github.com/apache/doris/pull/45310#issuecomment-2540670565 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-12 Thread via GitHub
morrySnow commented on code in PR #45310: URL: https://github.com/apache/doris/pull/45310#discussion_r1883264639 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/AddMinMax.java: ## @@ -326,7 +326,10 @@ private Map getExprMinMaxValues(UnknownValue valu

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-12 Thread via GitHub
github-actions[bot] commented on PR #45310: URL: https://github.com/apache/doris/pull/45310#issuecomment-2540442286 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-12 Thread via GitHub
github-actions[bot] commented on PR #45310: URL: https://github.com/apache/doris/pull/45310#issuecomment-2540442313 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-12 Thread via GitHub
englefly commented on code in PR #45310: URL: https://github.com/apache/doris/pull/45310#discussion_r1883189291 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/RangeInference.java: ## @@ -130,10 +132,22 @@ private ValueDesc simplify(ExpressionRewriteC

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-12 Thread via GitHub
yujun777 commented on PR #45310: URL: https://github.com/apache/doris/pull/45310#issuecomment-2540425162 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [opt](nereids) range inference convert isnull to EmptyValue [doris]

2024-12-11 Thread via GitHub
yujun777 commented on PR #45310: URL: https://github.com/apache/doris/pull/45310#issuecomment-2537523067 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns