morningman merged PR #41994:
URL: https://github.com/apache/doris/pull/41994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.a
github-actions[bot] commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2469481676
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2468163143
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
doris-robot commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2466621286
TeamCity be ut coverage result:
Function Coverage: 37.91% (9868/26029)
Line Coverage: 29.11% (82315/282803)
Region Coverage: 28.25% (42359/149942)
Branch Coverage: 24.8
morningman commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2466594620
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
morningman commented on code in PR #41994:
URL: https://github.com/apache/doris/pull/41994#discussion_r1833518433
##
be/src/runtime/cluster_info.h:
##
@@ -0,0 +1,47 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See
morningman commented on code in PR #41994:
URL: https://github.com/apache/doris/pull/41994#discussion_r1833518229
##
gensrc/thrift/HeartbeatService.thrift:
##
@@ -43,6 +43,8 @@ struct TMasterInfo {
11: optional string cloud_unique_id;
// See configuration item Config.j
github-actions[bot] commented on code in PR #41994:
URL: https://github.com/apache/doris/pull/41994#discussion_r1833522893
##
be/src/runtime/cluster_info.h:
##
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
morningman commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2463453412
> how do we get it tested?
already described in PR description. But we also need test it in a multi
node env
--
This is an automated message from the Apache Git Service.
To re
morningman commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2463451754
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
doris-robot commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2462915191
TeamCity be ut coverage result:
Function Coverage: 37.90% (9865/26028)
Line Coverage: 29.06% (82054/282361)
Region Coverage: 28.29% (42269/149435)
Branch Coverage: 24.8
gavinchou commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2462837480
how do we get it tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
gavinchou commented on code in PR #41994:
URL: https://github.com/apache/doris/pull/41994#discussion_r1833088938
##
be/src/runtime/cluster_info.h:
##
@@ -0,0 +1,47 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See
github-actions[bot] commented on code in PR #41994:
URL: https://github.com/apache/doris/pull/41994#discussion_r1832492152
##
be/src/runtime/cluster_info.h:
##
@@ -0,0 +1,47 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
morningman commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2462651090
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
github-actions[bot] commented on code in PR #41994:
URL: https://github.com/apache/doris/pull/41994#discussion_r1832492152
##
be/src/runtime/cluster_info.h:
##
@@ -0,0 +1,47 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
morningman commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2461932206
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
morningman commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2461909270
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
github-actions[bot] commented on code in PR #41994:
URL: https://github.com/apache/doris/pull/41994#discussion_r1831369790
##
be/src/agent/heartbeat_server.cpp:
##
@@ -291,8 +306,8 @@ Status HeartbeatServer::_heartbeat(const TMasterInfo&
master_info) {
Status create_heartbea
github-actions[bot] commented on code in PR #41994:
URL: https://github.com/apache/doris/pull/41994#discussion_r1803463119
##
be/src/http/http_headers.cpp:
##
@@ -94,5 +94,6 @@ const char* HttpHeaders::WEBSOCKET_PROTOCOL =
"WebSocket-Protocol";
const char* HttpHeaders::WWW_AUT
doris-robot commented on PR #41994:
URL: https://github.com/apache/doris/pull/41994#issuecomment-2417343154
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
morningman opened a new pull request, #41994:
URL: https://github.com/apache/doris/pull/41994
## Proposed changes
Issue Number: close #xxx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
22 matches
Mail list logo