Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-07 Thread via GitHub
sollhui commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2274884312 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2273426474 ClickBench: Total hot run time: 30.38 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2273414975 TPC-DS: Total hot run time: 168750 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2273393819 TPC-H: Total hot run time: 41638 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-07 Thread via GitHub
sollhui commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2273240164 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-07 Thread via GitHub
sollhui commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2273231669 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2272832186 ClickBench: Total hot run time: 30.49 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2272822776 TPC-DS: Total hot run time: 169813 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-07 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2272805143 TPC-H: Total hot run time: 41324 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-07 Thread via GitHub
sollhui commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2272772939 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271722796 ClickBench: Total hot run time: 29.76 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271713618 TPC-DS: Total hot run time: 167313 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271695586 TPC-H: Total hot run time: 41470 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
github-actions[bot] commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271665172 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
sollhui commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271653133 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
github-actions[bot] commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271301255 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
sollhui commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271286673 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271226110 ClickBench: Total hot run time: 29.84 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271214545 TPC-DS: Total hot run time: 168590 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271193111 TPC-H: Total hot run time: 41622 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
github-actions[bot] commented on code in PR #38960: URL: https://github.com/apache/doris/pull/38960#discussion_r1705442316 ## be/src/util/byte_buffer.h: ## @@ -23,19 +23,21 @@ #include #include "common/logging.h" +#include "vec/common/allocator.h" +#include "vec/common/allo

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
sollhui commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271151038 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271123482 ClickBench: Total hot run time: 30.24 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271113417 TPC-DS: Total hot run time: 169861 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271094641 TPC-H: Total hot run time: 41825 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
github-actions[bot] commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271022071 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
sollhui commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2271008670 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2270933822 ClickBench: Total hot run time: 30 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools Cli

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2270923326 TPC-DS: Total hot run time: 168884 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2270901948 TPC-H: Total hot run time: 41429 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
github-actions[bot] commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2270895803 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
github-actions[bot] commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2270895728 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
github-actions[bot] commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2270834034 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
doris-robot commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2270819414 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
sollhui commented on PR #38960: URL: https://github.com/apache/doris/pull/38960#issuecomment-2270819540 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator [doris]

2024-08-06 Thread via GitHub
sollhui opened a new pull request, #38960: URL: https://github.com/apache/doris/pull/38960 At present, the memory allocation of `ByteBuffer` is done through the `new` keyword. Now, it is uniformly allocated by `Allocator` for the following purposes: 1. Unified memory allocation for more