yiguolei merged PR #45719:
URL: https://github.com/apache/doris/pull/45719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apa
github-actions[bot] commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2560700142
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2560700119
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2560685128
ClickBench: Total hot run time: 32.05 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2560681457
TPC-DS: Total hot run time: 197093 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2560671251
TeamCity be ut coverage result:
Function Coverage: 38.80% (10095/26016)
Line Coverage: 29.79% (85158/285897)
Region Coverage: 28.91% (43489/150426)
Branch Coverage: 25.
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2560672297
TPC-H: Total hot run time: 33512 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
xinyiZzz commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2560613680
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
xinyiZzz commented on code in PR #45719:
URL: https://github.com/apache/doris/pull/45719#discussion_r1896304938
##
be/src/olap/lru_cache.cpp:
##
@@ -289,21 +289,35 @@ void LRUCache::_lru_append(LRUHandle* list, LRUHandle* e)
{
}
Cache::Handle* LRUCache::lookup(const CacheKe
yiguolei commented on code in PR #45719:
URL: https://github.com/apache/doris/pull/45719#discussion_r1895773882
##
be/src/olap/lru_cache.cpp:
##
@@ -289,21 +289,35 @@ void LRUCache::_lru_append(LRUHandle* list, LRUHandle* e)
{
}
Cache::Handle* LRUCache::lookup(const CacheKe
xinyiZzz commented on code in PR #45719:
URL: https://github.com/apache/doris/pull/45719#discussion_r1895729000
##
be/src/olap/lru_cache.cpp:
##
@@ -419,13 +474,18 @@ Cache::Handle* LRUCache::insert(const CacheKey& key,
uint32_t hash, void* value,
// because charge at this
xinyiZzz commented on code in PR #45719:
URL: https://github.com/apache/doris/pull/45719#discussion_r1895725719
##
be/src/olap/lru_cache.cpp:
##
@@ -476,14 +545,15 @@ void LRUCache::erase(const CacheKey& key, uint32_t hash) {
e = _table.remove(key, hash);
if (e
xinyiZzz commented on code in PR #45719:
URL: https://github.com/apache/doris/pull/45719#discussion_r1895725719
##
be/src/olap/lru_cache.cpp:
##
@@ -476,14 +545,15 @@ void LRUCache::erase(const CacheKey& key, uint32_t hash) {
e = _table.remove(key, hash);
if (e
yiguolei commented on code in PR #45719:
URL: https://github.com/apache/doris/pull/45719#discussion_r1895714436
##
be/src/olap/lru_cache.cpp:
##
@@ -476,14 +545,15 @@ void LRUCache::erase(const CacheKey& key, uint32_t hash) {
e = _table.remove(key, hash);
if (e
yiguolei commented on code in PR #45719:
URL: https://github.com/apache/doris/pull/45719#discussion_r1895708455
##
be/src/olap/lru_cache.cpp:
##
@@ -419,13 +474,18 @@ Cache::Handle* LRUCache::insert(const CacheKey& key,
uint32_t hash, void* value,
// because charge at this
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2558373544
ClickBench: Total hot run time: 31.45 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2558372040
TPC-DS: Total hot run time: 196789 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2558368967
TeamCity be ut coverage result:
Function Coverage: 38.88% (10134/26065)
Line Coverage: 29.81% (85308/286184)
Region Coverage: 28.94% (43573/150548)
Branch Coverage: 25.
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2558368292
TPC-H: Total hot run time: 32498 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
xinyiZzz commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2558354015
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2557088523
ClickBench: Total hot run time: 31.71 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2557077507
TPC-DS: Total hot run time: 190137 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2557058160
TPC-H: Total hot run time: 32583 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
xinyiZzz commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2556925157
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2556572755
ClickBench: Total hot run time: 31.32 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2556563955
TPC-DS: Total hot run time: 195914 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2556545001
TPC-H: Total hot run time: 32708 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
xinyiZzz commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2556420523
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
xinyiZzz opened a new pull request, #45719:
URL: https://github.com/apache/doris/pull/45719
### What problem does this PR solve?
Storage page cache uses plain LRU Cache, occasional batch operations can
cause "cache pollution" in plain LRU Cache. This will cause hotspot data to be
squ
Thearas commented on PR #45719:
URL: https://github.com/apache/doris/pull/45719#issuecomment-2556420414
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
github-actions[bot] closed pull request #28794: [improvement](memory) Storage
page cache use LRU-K cache, K=2
URL: https://github.com/apache/doris/pull/28794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
github-actions[bot] commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-2354244532
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of
keeping the PR queue manageable
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1963438643
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit c0afcf21c73fb5bb7d3f240e1e1b3e2916ef6d10 with
default session variables
Stream
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1963435389
ClickBench: Total hot run time: 28.83 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1963429718
TPC-DS: Total hot run time: 175616 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1963418371
TPC-H: Total hot run time: 35500 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1963409928
TeamCity be ut coverage result:
Function Coverage: 35.73% (8548/23924)
Line Coverage: 27.54% (69399/251976)
Region Coverage: 26.70% (36008/134848)
Branch Coverage: 23.5
github-actions[bot] commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1963387982
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xinyiZzz commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1963377663
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
github-actions[bot] commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1963365034
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xinyiZzz commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1963355825
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1961018668
TeamCity be ut coverage result:
Function Coverage: 35.72% (8549/23936)
Line Coverage: 27.55% (69419/251951)
Region Coverage: 26.71% (36016/134827)
Branch Coverage: 23.5
xinyiZzz commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1960957704
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
xinyiZzz commented on code in PR #28794:
URL: https://github.com/apache/doris/pull/28794#discussion_r1500378381
##
be/src/olap/lru_cache.cpp:
##
@@ -231,18 +231,29 @@ void LRUCache::_lru_append(LRUHandle* list, LRUHandle* e)
{
}
Cache::Handle* LRUCache::lookup(const CacheKe
yiguolei commented on code in PR #28794:
URL: https://github.com/apache/doris/pull/28794#discussion_r1435411670
##
be/src/olap/lru_cache.cpp:
##
@@ -347,16 +358,48 @@ bool LRUCache::_check_element_count_limit() {
return _element_count_capacity != 0 && _table.element_count()
yiguolei commented on code in PR #28794:
URL: https://github.com/apache/doris/pull/28794#discussion_r1435411638
##
be/src/olap/lru_cache.cpp:
##
@@ -231,18 +231,29 @@ void LRUCache::_lru_append(LRUHandle* list, LRUHandle* e)
{
}
Cache::Handle* LRUCache::lookup(const CacheKe
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1866097383
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 32ebcb7ab0e1acf07d88a9eee3698de7e738da0d,
data reload: false
run tpc
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1866066089
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 42.25 seconds
stream load tsv: 572 seconds loaded 74807831229 Bytes,
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1866066107
TeamCity be ut coverage result:
Function Coverage: 36.47% (8536/23406)
Line Coverage: 28.60% (69443/242848)
Region Coverage: 27.63% (35954/130124)
Branch Coverage: 24.3
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1865994192
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit bfd3a073833fc389f528039ed53c428e901d355c,
data reload: false
run tpc
xinyiZzz commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1865962947
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1865923593
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 42.51 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes,
doris-robot commented on PR #28794:
URL: https://github.com/apache/doris/pull/28794#issuecomment-1865886130
TeamCity be ut coverage result:
Function Coverage: 36.47% (8537/23407)
Line Coverage: 28.60% (69450/242820)
Region Coverage: 27.63% (35945/130105)
Branch Coverage: 24.3
53 matches
Mail list logo
