Re: [PR] [improve] adjust the code framework related to CDC. [doris-flink-connector]

2024-02-28 Thread via GitHub
JNSimba merged PR #319: URL: https://github.com/apache/doris-flink-connector/pull/319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

Re: [PR] [improve] adjust the code framework related to CDC. [doris-flink-connector]

2024-02-27 Thread via GitHub
JNSimba commented on PR #319: URL: https://github.com/apache/doris-flink-connector/pull/319#issuecomment-1968278627 checkstyle failed, PTAL @bingquanzhao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [improve] adjust the code framework related to CDC. [doris-flink-connector]

2024-02-27 Thread via GitHub
JNSimba commented on code in PR #319: URL: https://github.com/apache/doris-flink-connector/pull/319#discussion_r1505229085 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/CdcDataChange.java: ## @@ -0,0 +1,35 @@ +// Licensed to t

Re: [PR] [improve] adjust the code framework related to CDC. [doris-flink-connector]

2024-02-27 Thread via GitHub
JNSimba commented on code in PR #319: URL: https://github.com/apache/doris-flink-connector/pull/319#discussion_r1505229085 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/CdcDataChange.java: ## @@ -0,0 +1,35 @@ +// Licensed to t

Re: [PR] [improve] adjust the code framework related to CDC. [doris-flink-connector]

2024-02-27 Thread via GitHub
bingquanzhao commented on code in PR #319: URL: https://github.com/apache/doris-flink-connector/pull/319#discussion_r1503929828 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/CdcDataChange.java: ## @@ -0,0 +1,35 @@ +// Licensed

Re: [PR] [improve] adjust the code framework related to CDC. [doris-flink-connector]

2024-02-26 Thread via GitHub
JNSimba commented on code in PR #319: URL: https://github.com/apache/doris-flink-connector/pull/319#discussion_r1503537095 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/CdcSchemaChange.java: ## @@ -0,0 +1,34 @@ +// Licensed to

Re: [PR] [improve] adjust the code framework related to CDC. [doris-flink-connector]

2024-02-26 Thread via GitHub
JNSimba commented on code in PR #319: URL: https://github.com/apache/doris-flink-connector/pull/319#discussion_r1503538532 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/CdcDataChange.java: ## @@ -0,0 +1,35 @@ +// Licensed to t

Re: [PR] [improve] adjust the code framework related to CDC. [doris-flink-connector]

2024-02-26 Thread via GitHub
JNSimba commented on code in PR #319: URL: https://github.com/apache/doris-flink-connector/pull/319#discussion_r1503537095 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/CdcSchemaChange.java: ## @@ -0,0 +1,34 @@ +// Licensed to