Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-26 Thread via GitHub
yiguolei merged PR #30412: URL: https://github.com/apache/doris/pull/30412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-26 Thread via GitHub
github-actions[bot] commented on PR #30412: URL: https://github.com/apache/doris/pull/30412#issuecomment-1912930112 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-26 Thread via GitHub
github-actions[bot] commented on PR #30412: URL: https://github.com/apache/doris/pull/30412#issuecomment-1912930101 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-26 Thread via GitHub
HappenLee commented on code in PR #30412: URL: https://github.com/apache/doris/pull/30412#discussion_r1467654056 ## be/src/vec/exec/vpartition_sort_node.cpp: ## @@ -79,13 +119,18 @@ Status VPartitionSortNode::prepare(RuntimeState* state) { _get_sorted_timer = ADD_TIMER(runt

Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-25 Thread via GitHub
doris-robot commented on PR #30412: URL: https://github.com/apache/doris/pull/30412#issuecomment-1911613331 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit b75aa7d6f8c43159d340190a6ab5be616e2b2e1f with default session variables Stream

Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-25 Thread via GitHub
doris-robot commented on PR #30412: URL: https://github.com/apache/doris/pull/30412#issuecomment-1911610652 ClickBench: Total hot run time: 30.39 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-25 Thread via GitHub
doris-robot commented on PR #30412: URL: https://github.com/apache/doris/pull/30412#issuecomment-1911605960 TPC-DS: Total hot run time: 186657 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-25 Thread via GitHub
doris-robot commented on PR #30412: URL: https://github.com/apache/doris/pull/30412#issuecomment-1911596617 TPC-H: Total hot run time: 39344 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #30412: URL: https://github.com/apache/doris/pull/30412#issuecomment-1911587324 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-25 Thread via GitHub
zhangstar333 commented on PR #30412: URL: https://github.com/apache/doris/pull/30412#issuecomment-1911580028 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #30412: URL: https://github.com/apache/doris/pull/30412#issuecomment-1911553787 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-25 Thread via GitHub
zhangstar333 commented on PR #30412: URL: https://github.com/apache/doris/pull/30412#issuecomment-1911545921 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [improve](node) refactor partition sort node to reduce memory use [doris]

2024-01-25 Thread via GitHub
zhangstar333 opened a new pull request, #30412: URL: https://github.com/apache/doris/pull/30412 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](ma