Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-11 Thread via GitHub
dataroaring merged PR #27957: URL: https://github.com/apache/doris/pull/27957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-11 Thread via GitHub
mymeiyi commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849822213 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-11 Thread via GitHub
doris-robot commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849672577 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.18 seconds stream load tsv: 575 seconds loaded 74807831229 Bytes,

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-11 Thread via GitHub
doris-robot commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849666818 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit c5521b95b94a12c37edc5ef611f291f290c69104, data reload: false

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-11 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849649139 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-11 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849624412 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-11 Thread via GitHub
mymeiyi commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849612673 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-11 Thread via GitHub
doris-robot commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849511924 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.56 seconds stream load tsv: 575 seconds loaded 74807831229 Bytes,

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-10 Thread via GitHub
doris-robot commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849497769 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 5bde59db00950f89abb02b77e05598291bc54cb8, data reload: false

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-10 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849471264 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-10 Thread via GitHub
mymeiyi commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849463450 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-10 Thread via GitHub
doris-robot commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849419490 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.51 seconds stream load tsv: 576 seconds loaded 74807831229 Bytes,

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-10 Thread via GitHub
doris-robot commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849407286 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 8a4a3eb067d9791dc1940659e110cc8fecf4eaf4, data reload: false

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-10 Thread via GitHub
mymeiyi commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849383041 run clickbench -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-10 Thread via GitHub
doris-robot commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849359986 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 8a4a3eb067d9791dc1940659e110cc8fecf4eaf4, data reload: false

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-10 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849265274 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-10 Thread via GitHub
mymeiyi commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1849261390 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-07 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1846630408 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-06 Thread via GitHub
doris-robot commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1844375928 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 869fffd5703e6ecc10cfea9bb6e0003f39f1482d, data reload: false

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-06 Thread via GitHub
doris-robot commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1844369245 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 43.55 seconds stream load tsv: 581 seconds loaded 74807831229 Bytes,

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-06 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1844152520 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-06 Thread via GitHub
mymeiyi commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1844145450 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-05 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1842188591 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-05 Thread via GitHub
dataroaring commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1842180333 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-05 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1842149958 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-05 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-184215 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-05 Thread via GitHub
dataroaring commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1842148130 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-05 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1842040619 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-05 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1842038734 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-05 Thread via GitHub
doris-robot commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1840595811 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 38d4aea214c7d5b4addcdf4605917e7e1a98eb64, data reload: false

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-05 Thread via GitHub
dataroaring commented on code in PR #27957: URL: https://github.com/apache/doris/pull/27957#discussion_r1415400949 ## gensrc/thrift/FrontendService.thrift: ## @@ -652,8 +652,9 @@ struct TStreamLoadPutRequest { // only valid when file type is CSV 52: optional i8 escape

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-05 Thread via GitHub
doris-robot commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1840549140 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.77 seconds stream load tsv: 565 seconds loaded 74807831229 Bytes,

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-04 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1840195961 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-04 Thread via GitHub
mymeiyi commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1840181615 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-04 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1838478815 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-04 Thread via GitHub
mymeiyi commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1838465057 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-04 Thread via GitHub
github-actions[bot] commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1838420058 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-04 Thread via GitHub
mymeiyi commented on PR #27957: URL: https://github.com/apache/doris/pull/27957#issuecomment-1838406607 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] [improve](group commit) Group commit support skip wal [doris]

2023-12-04 Thread via GitHub
mymeiyi opened a new pull request, #27957: URL: https://github.com/apache/doris/pull/27957 ## Proposed changes Group commit support two modes: * `group_commit = eventual_consistency` write with wal, and returned once the block is consumed. * `group_commit = strong_consistency` w