Re: [PR] [fix] add null check before accessing pointer [doris]

2024-08-04 Thread via GitHub
yiguolei merged PR #38817: URL: https://github.com/apache/doris/pull/38817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix] add null check before accessing pointer [doris]

2024-08-04 Thread via GitHub
github-actions[bot] commented on PR #38817: URL: https://github.com/apache/doris/pull/38817#issuecomment-2267427339 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix] add null check before accessing pointer [doris]

2024-08-04 Thread via GitHub
github-actions[bot] commented on PR #38817: URL: https://github.com/apache/doris/pull/38817#issuecomment-2267427321 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix] add null check before accessing pointer [doris]

2024-08-03 Thread via GitHub
doris-robot commented on PR #38817: URL: https://github.com/apache/doris/pull/38817#issuecomment-2266648156 ClickBench: Total hot run time: 30.79 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix] add null check before accessing pointer [doris]

2024-08-03 Thread via GitHub
doris-robot commented on PR #38817: URL: https://github.com/apache/doris/pull/38817#issuecomment-2266646529 TPC-DS: Total hot run time: 168318 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix] add null check before accessing pointer [doris]

2024-08-03 Thread via GitHub
doris-robot commented on PR #38817: URL: https://github.com/apache/doris/pull/38817#issuecomment-2266644042 TPC-H: Total hot run time: 41351 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix] add null check before accessing pointer [doris]

2024-08-03 Thread via GitHub
github-actions[bot] commented on PR #38817: URL: https://github.com/apache/doris/pull/38817#issuecomment-2266635340 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix] add null check before accessing pointer [doris]

2024-08-03 Thread via GitHub
Vallishp commented on PR #38817: URL: https://github.com/apache/doris/pull/38817#issuecomment-2266633573 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] add null check before accessing pointer [doris]

2024-08-03 Thread via GitHub
doris-robot commented on PR #38817: URL: https://github.com/apache/doris/pull/38817#issuecomment-2266633532 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix] add null check before accessing pointer [doris]

2024-08-03 Thread via GitHub
Vallishp opened a new pull request, #38817: URL: https://github.com/apache/doris/pull/38817 ## Proposed changes Issue Number: close #xxx re2_ptr can possible null from code review. fixed code to handle it. -- This is an automated message from the Apache Git Service