Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
dataroaring merged PR #40273: URL: https://github.com/apache/doris/pull/40273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2344692254 ClickBench: Total hot run time: 31.24 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2344683518 TPC-DS: Total hot run time: 199066 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2344664197 TPC-H: Total hot run time: 38566 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2344659595 TeamCity be ut coverage result: Function Coverage: 36.89% (9455/25629) Line Coverage: 28.25% (77784/275302) Region Coverage: 27.66% (40157/145193) Branch Coverage: 24.2

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
Vallishp commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2344601127 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
github-actions[bot] commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2343912374 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2343129037 ClickBench: Total hot run time: 32.08 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2343117501 TPC-DS: Total hot run time: 196890 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2343088644 TPC-H: Total hot run time: 38182 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2343074780 TeamCity be ut coverage result: Function Coverage: 36.88% (9449/25624) Line Coverage: 28.25% (77744/275159) Region Coverage: 27.65% (40124/145119) Branch Coverage: 24.2

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-11 Thread via GitHub
Vallishp commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2343002910 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-10 Thread via GitHub
doris-robot commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2341851881 TPC-H: Total hot run time: 38454 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-09 Thread via GitHub
doris-robot commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2339616593 TPC-H: Total hot run time: 38384 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-09 Thread via GitHub
yiguolei commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2339578183 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-05 Thread via GitHub
github-actions[bot] commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2332166450 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-02 Thread via GitHub
github-actions[bot] commented on code in PR #40273: URL: https://github.com/apache/doris/pull/40273#discussion_r1740781512 ## be/test/vec/exec/vfile_scanner_exception_test.cpp: ## @@ -0,0 +1,307 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-02 Thread via GitHub
github-actions[bot] commented on code in PR #40273: URL: https://github.com/apache/doris/pull/40273#discussion_r1740775902 ## be/test/vec/exec/vfile_scanner_exception_test.cpp: ## @@ -0,0 +1,307 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contri

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-02 Thread via GitHub
Vallishp commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2324528318 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-02 Thread via GitHub
doris-robot commented on PR #40273: URL: https://github.com/apache/doris/pull/40273#issuecomment-2324525059 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix] _cur_reader can be null in exception cases in VFileScanner [doris]

2024-09-02 Thread via GitHub
Vallishp opened a new pull request, #40273: URL: https://github.com/apache/doris/pull/40273 ## Proposed changes Issue Number: close #xxx cur_reader pointer can be null in VFileScanner. can cause BE crash [ RUN ] VfileScannerExcepTest.failure_case AddressSanitizer:DEAD