Re: [PR] [fix] (variant) add serialize and deserialize [doris]

2024-12-16 Thread via GitHub
eldenmoon merged PR #45487: URL: https://github.com/apache/doris/pull/45487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix] (variant) add serialize and deserialize [doris]

2024-12-16 Thread via GitHub
eldenmoon commented on code in PR #45487: URL: https://github.com/apache/doris/pull/45487#discussion_r1886817376 ## be/src/vec/columns/column_object.cpp: ## @@ -1000,16 +1014,18 @@ void ColumnObject::Subcolumn::serialize_to_sparse_column(ColumnString* key, std: // remove

Re: [PR] [fix] (variant) add serialize and deserialize [doris]

2024-12-16 Thread via GitHub
eldenmoon commented on code in PR #45487: URL: https://github.com/apache/doris/pull/45487#discussion_r1886811855 ## be/src/vec/columns/column_object.cpp: ## @@ -1020,6 +1036,110 @@ void ColumnObject::Subcolumn::serialize_to_sparse_column(ColumnString* key, std:

Re: [PR] [fix] (variant) add serialize and deserialize [doris]

2024-12-16 Thread via GitHub
eldenmoon commented on code in PR #45487: URL: https://github.com/apache/doris/pull/45487#discussion_r1886791769 ## be/src/vec/columns/column_object.cpp: ## @@ -808,8 +812,13 @@ ColumnObject::ColumnObject(Subcolumns&& subcolumns_, bool is_nullable_) check_consistency(); }

Re: [PR] [fix] (variant) add serialize and deserialize [doris]

2024-12-16 Thread via GitHub
github-actions[bot] commented on code in PR #45487: URL: https://github.com/apache/doris/pull/45487#discussion_r1886676066 ## be/src/vec/columns/column_object.cpp: ## @@ -982,6 +997,149 @@ void ColumnObject::Subcolumn::get(size_t n, Field& res) const {

Re: [PR] [fix] (variant) add serialize and deserialize [doris]

2024-12-16 Thread via GitHub
hello-stephen commented on PR #45487: URL: https://github.com/apache/doris/pull/45487#issuecomment-2545388410 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro

[PR] [fix] (variant) add serialize and deserialize [doris]

2024-12-16 Thread via GitHub
csun5285 opened a new pull request, #45487: URL: https://github.com/apache/doris/pull/45487 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test