Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-15 Thread via GitHub
airborne12 merged PR #44994: URL: https://github.com/apache/doris/pull/44994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-15 Thread via GitHub
github-actions[bot] commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2544422465 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-11 Thread via GitHub
doris-robot commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2535980229 TeamCity be ut coverage result: Function Coverage: 38.81% (10119/26071) Line Coverage: 29.77% (85005/285535) Region Coverage: 28.79% (43575/151329) Branch Coverage: 25.

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-11 Thread via GitHub
csun5285 commented on code in PR #44994: URL: https://github.com/apache/doris/pull/44994#discussion_r1880109837 ## be/test/olap/rowset/segment_v2/inverted_index/common/inverted_index_gc_binlogs_test.cpp: ## @@ -0,0 +1,170 @@ +// Licensed to the Apache Software Foundation (ASF) u

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-11 Thread via GitHub
csun5285 commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2535856164 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-11 Thread via GitHub
qidaye commented on code in PR #44994: URL: https://github.com/apache/doris/pull/44994#discussion_r1879690037 ## be/test/olap/rowset/segment_v2/inverted_index/common/inverted_index_gc_binlogs_test.cpp: ## @@ -0,0 +1,170 @@ +// Licensed to the Apache Software Foundation (ASF) und

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-10 Thread via GitHub
doris-robot commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2533637521 TeamCity be ut coverage result: Function Coverage: 38.85% (10119/26044) Line Coverage: 29.77% (84946/285331) Region Coverage: 28.81% (43560/151213) Branch Coverage: 25.

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-10 Thread via GitHub
csun5285 commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2533596478 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-10 Thread via GitHub
github-actions[bot] commented on code in PR #44994: URL: https://github.com/apache/doris/pull/44994#discussion_r1879312363 ## be/src/http/action/download_binlog_action.cpp: ## @@ -144,8 +144,19 @@ void handle_get_segment_index_file(StorageEngine& engine, HttpRequest* req,

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-10 Thread via GitHub
doris-robot commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2531471533 TeamCity be ut coverage result: Function Coverage: 38.86% (10121/26044) Line Coverage: 29.77% (84933/285320) Region Coverage: 28.81% (43565/151206) Branch Coverage: 25.

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-10 Thread via GitHub
github-actions[bot] commented on code in PR #44994: URL: https://github.com/apache/doris/pull/44994#discussion_r1877853208 ## be/test/olap/rowset/segment_v2/inverted_index/common/inverted_index_gc_binlogs_test.cpp: ## @@ -0,0 +1,170 @@ +// Licensed to the Apache Software Foundat

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-10 Thread via GitHub
csun5285 commented on code in PR #44994: URL: https://github.com/apache/doris/pull/44994#discussion_r1877846497 ## be/src/olap/task/engine_storage_migration_task.cpp: ## @@ -409,8 +409,9 @@ Status EngineStorageMigrationTask::_copy_index_and_data_files( Inverted

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-10 Thread via GitHub
csun5285 commented on code in PR #44994: URL: https://github.com/apache/doris/pull/44994#discussion_r1877843657 ## be/src/olap/snapshot_manager.cpp: ## @@ -700,8 +700,10 @@ Status SnapshotManager::_create_snapshot_files(const TabletSharedPtr& ref_tablet Inv

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-10 Thread via GitHub
csun5285 commented on code in PR #44994: URL: https://github.com/apache/doris/pull/44994#discussion_r1877840619 ## be/src/olap/task/engine_storage_migration_task.cpp: ## @@ -409,8 +409,9 @@ Status EngineStorageMigrationTask::_copy_index_and_data_files( Inverted

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-10 Thread via GitHub
csun5285 commented on code in PR #44994: URL: https://github.com/apache/doris/pull/44994#discussion_r1877840167 ## be/src/olap/tablet.cpp: ## @@ -2653,10 +2629,22 @@ void Tablet::gc_binlogs(int64_t version) { // add binlog segment files and index files for (i

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-10 Thread via GitHub
csun5285 commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2531181173 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-09 Thread via GitHub
airborne12 commented on code in PR #44994: URL: https://github.com/apache/doris/pull/44994#discussion_r1877486298 ## be/src/olap/task/engine_storage_migration_task.cpp: ## @@ -409,8 +409,9 @@ Status EngineStorageMigrationTask::_copy_index_and_data_files( Invert

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-09 Thread via GitHub
airborne12 commented on code in PR #44994: URL: https://github.com/apache/doris/pull/44994#discussion_r1877485134 ## be/src/olap/tablet.cpp: ## @@ -2653,10 +2629,22 @@ void Tablet::gc_binlogs(int64_t version) { // add binlog segment files and index files for

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-09 Thread via GitHub
airborne12 commented on code in PR #44994: URL: https://github.com/apache/doris/pull/44994#discussion_r1877484503 ## be/src/olap/snapshot_manager.cpp: ## @@ -700,8 +700,10 @@ Status SnapshotManager::_create_snapshot_files(const TabletSharedPtr& ref_tablet I

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-06 Thread via GitHub
doris-robot commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2522663210 TeamCity be ut coverage result: Function Coverage: 38.54% (10022/26002) Line Coverage: 29.57% (84102/284380) Region Coverage: 28.65% (43188/150739) Branch Coverage: 25.

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-06 Thread via GitHub
csun5285 commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2522539594 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-06 Thread via GitHub
github-actions[bot] commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2522473319 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-06 Thread via GitHub
github-actions[bot] commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2522473251 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-05 Thread via GitHub
doris-robot commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2522281861 TeamCity be ut coverage result: Function Coverage: 38.53% (10021/26005) Line Coverage: 29.58% (84119/284399) Region Coverage: 28.64% (43179/150746) Branch Coverage: 25.

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-05 Thread via GitHub
csun5285 commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2522238794 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-05 Thread via GitHub
csun5285 commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2522234141 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-04 Thread via GitHub
doris-robot commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2516659929 TeamCity be ut coverage result: Function Coverage: 38.48% (10007/26007) Line Coverage: 29.53% (83904/284176) Region Coverage: 28.62% (43109/150610) Branch Coverage: 25.

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-04 Thread via GitHub
csun5285 commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2516569622 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-04 Thread via GitHub
doris-robot commented on PR #44994: URL: https://github.com/apache/doris/pull/44994#issuecomment-2516568965 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+proce

[PR] [fix] (inverted index) fix index file in gc binlogs [doris]

2024-12-04 Thread via GitHub
csun5285 opened a new pull request, #44994: URL: https://github.com/apache/doris/pull/44994 ### What problem does this PR solve? Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit