Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-23 Thread via GitHub
yiguolei merged PR #32569: URL: https://github.com/apache/doris/pull/32569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-22 Thread via GitHub
ziyanTOP commented on PR #32569: URL: https://github.com/apache/doris/pull/32569#issuecomment-2016324821 done @924060929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-22 Thread via GitHub
ziyanTOP commented on PR #32569: URL: https://github.com/apache/doris/pull/32569#issuecomment-2016264603 > @ziyanTOP good job👍🏻, would you submit a fix pr for branch-2.0? ok, I will -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-22 Thread via GitHub
doris-robot commented on PR #32569: URL: https://github.com/apache/doris/pull/32569#issuecomment-2015061272 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 912a6c0d9ed5f09b602a2d102011090864b530e2 with default session variables Stream

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-22 Thread via GitHub
doris-robot commented on PR #32569: URL: https://github.com/apache/doris/pull/32569#issuecomment-2015056115 TPC-DS: Total hot run time: 186861 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-22 Thread via GitHub
doris-robot commented on PR #32569: URL: https://github.com/apache/doris/pull/32569#issuecomment-2015034802 TPC-H: Total hot run time: 38474 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-22 Thread via GitHub
924060929 commented on PR #32569: URL: https://github.com/apache/doris/pull/32569#issuecomment-2014933122 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-22 Thread via GitHub
924060929 commented on PR #32569: URL: https://github.com/apache/doris/pull/32569#issuecomment-2014926319 @ziyanTOP good job👍🏻, would you submit a fix pr for branch-2.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #32569: URL: https://github.com/apache/doris/pull/32569#issuecomment-2014923868 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #32569: URL: https://github.com/apache/doris/pull/32569#issuecomment-2014923821 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-21 Thread via GitHub
ziyanTOP commented on code in PR #32569: URL: https://github.com/apache/doris/pull/32569#discussion_r1533203065 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DateLiteral.java: ## @@ -458,10 +458,10 @@ public DateTimeLiteral toBeginOfTheDay() {

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-20 Thread via GitHub
ziyanTOP commented on PR #32569: URL: https://github.com/apache/doris/pull/32569#issuecomment-2011160348 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-20 Thread via GitHub
ziyanTOP commented on code in PR #32569: URL: https://github.com/apache/doris/pull/32569#discussion_r1533203065 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DateLiteral.java: ## @@ -458,10 +458,10 @@ public DateTimeLiteral toBeginOfTheDay() {

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-20 Thread via GitHub
yiguolei commented on code in PR #32569: URL: https://github.com/apache/doris/pull/32569#discussion_r1532278555 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DateLiteral.java: ## @@ -458,10 +458,10 @@ public DateTimeLiteral toBeginOfTheDay() {

Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-20 Thread via GitHub
doris-robot commented on PR #32569: URL: https://github.com/apache/doris/pull/32569#issuecomment-2009513678 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]

2024-03-20 Thread via GitHub
ziyanTOP opened a new pull request, #32569: URL: https://github.com/apache/doris/pull/32569 ## Proposed changes Issue Number: close #32329 Avoid '24:00:00' time literal for datetimev1 column after handling by date function rewrite in nereids planner ## Further comme