Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-25 Thread via GitHub
dataroaring merged PR #45685: URL: https://github.com/apache/doris/pull/45685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-24 Thread via GitHub
github-actions[bot] commented on code in PR #45685: URL: https://github.com/apache/doris/pull/45685#discussion_r1893331371 ## cloud/src/meta-service/meta_service_resource.cpp: ## @@ -523,9 +523,18 @@ static void set_default_vault_log_helper(const InstanceInfoPB& instance,

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-24 Thread via GitHub
MoanasDaddyXu commented on code in PR #45685: URL: https://github.com/apache/doris/pull/45685#discussion_r1897149889 ## regression-test/suites/vault_p0/alter/test_alter_vault_name.groovy: ## @@ -0,0 +1,232 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-24 Thread via GitHub
github-actions[bot] commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2561660689 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-24 Thread via GitHub
github-actions[bot] commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2561660678 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-24 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2561599094 ClickBench: Total hot run time: 31.24 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-24 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2561597249 TPC-DS: Total hot run time: 196210 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-24 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2561592651 TPC-H: Total hot run time: 32408 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-24 Thread via GitHub
SWJTU-ZhangLei commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2561578861 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-24 Thread via GitHub
SWJTU-ZhangLei commented on code in PR #45685: URL: https://github.com/apache/doris/pull/45685#discussion_r1897072894 ## cloud/src/meta-service/meta_service_resource.cpp: ## @@ -523,9 +523,18 @@ static void set_default_vault_log_helper(const InstanceInfoPB& instance, LOG(I

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-24 Thread via GitHub
gavinchou commented on code in PR #45685: URL: https://github.com/apache/doris/pull/45685#discussion_r1896609819 ## cloud/src/meta-service/meta_service_resource.cpp: ## @@ -523,9 +523,18 @@ static void set_default_vault_log_helper(const InstanceInfoPB& instance, LOG(INFO)

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-24 Thread via GitHub
gavinchou commented on code in PR #45685: URL: https://github.com/apache/doris/pull/45685#discussion_r1896607858 ## gensrc/proto/cloud.proto: ## @@ -887,6 +887,9 @@ message AlterObjStoreInfoResponse { optional MetaServiceResponseStatus status = 1; optional string stora

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-23 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2560735325 ClickBench: Total hot run time: 32.43 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-23 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2560730688 TPC-DS: Total hot run time: 189786 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-23 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2560720607 TPC-H: Total hot run time: 39852 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-23 Thread via GitHub
SWJTU-ZhangLei commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2560689707 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-23 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2560574817 TPC-DS: Total hot run time: 196911 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-23 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2560567016 TPC-H: Total hot run time: 40243 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-23 Thread via GitHub
SWJTU-ZhangLei commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2560509777 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-22 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2558851612 ClickBench: Total hot run time: 33.79 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-22 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2558846979 TPC-DS: Total hot run time: 195955 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-22 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2558836942 TPC-H: Total hot run time: 39758 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-22 Thread via GitHub
SWJTU-ZhangLei commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2558760825 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-22 Thread via GitHub
SWJTU-ZhangLei commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2558757728 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-19 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2556210999 ClickBench: Total hot run time: 33.53 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-19 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2556206298 TPC-DS: Total hot run time: 196967 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-19 Thread via GitHub
doris-robot commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2556179545 TPC-H: Total hot run time: 39897 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-19 Thread via GitHub
github-actions[bot] commented on code in PR #45685: URL: https://github.com/apache/doris/pull/45685#discussion_r1893331371 ## cloud/src/meta-service/meta_service_resource.cpp: ## @@ -523,9 +523,18 @@ static void set_default_vault_log_helper(const InstanceInfoPB& instance,

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-19 Thread via GitHub
SWJTU-ZhangLei commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2556092360 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-19 Thread via GitHub
hello-stephen commented on PR #45685: URL: https://github.com/apache/doris/pull/45685#issuecomment-2556091869 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro

[PR] [fix](vault) Fix bugs about altering storage vault name [doris]

2024-12-19 Thread via GitHub
SWJTU-ZhangLei opened a new pull request, #45685: URL: https://github.com/apache/doris/pull/45685 * fix altering storage name but not writing disk in meta-service * check vault if existed when altering stoarge vault name ### What problem does this PR solve? Issue Number: clos