Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
dataroaring merged PR #35537: URL: https://github.com/apache/doris/pull/35537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #35537: URL: https://github.com/apache/doris/pull/35537#issuecomment-2136370537 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
dataroaring commented on code in PR #35537: URL: https://github.com/apache/doris/pull/35537#discussion_r1617109342 ## be/src/util/block_compression.cpp: ## @@ -669,7 +669,7 @@ class SnappySlicesSource : public snappy::Source { // REQUIRES: Available() >= n void Skip(si

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
cambyzju commented on code in PR #35537: URL: https://github.com/apache/doris/pull/35537#discussion_r1617102632 ## be/src/util/block_compression.cpp: ## @@ -669,7 +669,7 @@ class SnappySlicesSource : public snappy::Source { // REQUIRES: Available() >= n void Skip(size_

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
doris-robot commented on PR #35537: URL: https://github.com/apache/doris/pull/35537#issuecomment-2134852495 ClickBench: Total hot run time: 30.69 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
doris-robot commented on PR #35537: URL: https://github.com/apache/doris/pull/35537#issuecomment-2134842163 TPC-DS: Total hot run time: 172957 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
doris-robot commented on PR #35537: URL: https://github.com/apache/doris/pull/35537#issuecomment-2134819612 TeamCity be ut coverage result: Function Coverage: 35.77% (9005/25173) Line Coverage: 27.39% (74557/272170) Region Coverage: 26.61% (38572/144929) Branch Coverage: 23.4

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
doris-robot commented on PR #35537: URL: https://github.com/apache/doris/pull/35537#issuecomment-2134819619 TPC-H: Total hot run time: 40686 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #35537: URL: https://github.com/apache/doris/pull/35537#issuecomment-2134810472 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #35537: URL: https://github.com/apache/doris/pull/35537#issuecomment-2134794426 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #35537: URL: https://github.com/apache/doris/pull/35537#issuecomment-2134787766 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
dataroaring commented on PR #35537: URL: https://github.com/apache/doris/pull/35537#issuecomment-2134782017 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
dataroaring commented on PR #35537: URL: https://github.com/apache/doris/pull/35537#issuecomment-2134776841 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
doris-robot commented on PR #35537: URL: https://github.com/apache/doris/pull/35537#issuecomment-2134776560 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](snappy) avoid potential buffer overflow [doris]

2024-05-28 Thread via GitHub
dataroaring opened a new pull request, #35537: URL: https://github.com/apache/doris/pull/35537 If skip more than once when available is zero, then a buffer overflow occurs. ## Proposed changes ![Uploading telegram-cloud-photo-size-5-6244711526321733357-y.jpg…]() Issue