Re: [PR] [fix](recycler) Fix CountdownEvent error [doris]

2024-12-23 Thread via GitHub
github-actions[bot] commented on PR #45760: URL: https://github.com/apache/doris/pull/45760#issuecomment-2559975428 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](recycler) Fix CountdownEvent error [doris]

2024-12-23 Thread via GitHub
github-actions[bot] commented on PR #45760: URL: https://github.com/apache/doris/pull/45760#issuecomment-2559975481 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](recycler) Fix CountdownEvent error [doris]

2024-12-23 Thread via GitHub
gavinchou commented on code in PR #45760: URL: https://github.com/apache/doris/pull/45760#discussion_r1895919138 ## cloud/src/recycler/sync_executor.h: ## @@ -65,11 +69,27 @@ class SyncExecutor { *finished = false; return res; } -

Re: [PR] [fix](recycler) Fix CountdownEvent error [doris]

2024-12-23 Thread via GitHub
Yukang-Lian commented on PR #45760: URL: https://github.com/apache/doris/pull/45760#issuecomment-2559934838 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](recycler) Fix CountdownEvent error [doris]

2024-12-23 Thread via GitHub
gavinchou commented on code in PR #45760: URL: https://github.com/apache/doris/pull/45760#discussion_r1895742234 ## cloud/src/recycler/sync_executor.h: ## @@ -65,11 +66,21 @@ class SyncExecutor { *finished = false; return res; } -

Re: [PR] [fix](recycler) Fix CountdownEvent error [doris]

2024-12-23 Thread via GitHub
Yukang-Lian commented on PR #45760: URL: https://github.com/apache/doris/pull/45760#issuecomment-2559672151 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](recycler) Fix CountdownEvent error [doris]

2024-12-23 Thread via GitHub
gavinchou commented on code in PR #45760: URL: https://github.com/apache/doris/pull/45760#discussion_r1895737323 ## cloud/src/recycler/sync_executor.h: ## @@ -65,11 +66,21 @@ class SyncExecutor { *finished = false; return res; } -

Re: [PR] [fix](recycler) Fix CountdownEvent error [doris]

2024-12-22 Thread via GitHub
gavinchou commented on code in PR #45760: URL: https://github.com/apache/doris/pull/45760#discussion_r1894853620 ## cloud/src/recycler/sync_executor.h: ## @@ -70,6 +70,7 @@ class SyncExecutor { return res; } void reset() { Review Comment: also fix where it

Re: [PR] [fix](recycler) Fix CountdownEvent error [doris]

2024-12-21 Thread via GitHub
Yukang-Lian commented on PR #45760: URL: https://github.com/apache/doris/pull/45760#issuecomment-2558154984 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](recycler) Fix CountdownEvent error [doris]

2024-12-21 Thread via GitHub
Thearas commented on PR #45760: URL: https://github.com/apache/doris/pull/45760#issuecomment-2558154972 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](recycler) Fix CountdownEvent error [doris]

2024-12-21 Thread via GitHub
Yukang-Lian opened a new pull request, #45760: URL: https://github.com/apache/doris/pull/45760 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: Fix CountdownEvent error "Invoking add_count() after wait() was invoked"