morningman merged PR #49082:
URL: https://github.com/apache/doris/pull/49082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.a
doris-robot commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2771606528
TPC-DS: Total hot run time: 193008 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2771580180
TPC-H: Total hot run time: 33974 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
HappenLee commented on code in PR #49082:
URL: https://github.com/apache/doris/pull/49082#discussion_r2024645111
##
be/src/vec/exprs/vexpr.cpp:
##
@@ -371,20 +371,29 @@ Status VExpr::create_tree_from_thrift(const
std::vector& nodes, int*
std::stack> s;
s.emplace(root,
doris-robot commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2774845430
TPC-H: Total hot run time: 34371 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
hello-stephen commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2775193585
# BE UT Coverage Report
Increment line coverage `100.00% (9/9)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/11db53dcbb29253e81bb2e1e3a01375de
doris-robot commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2778746839
ClickBench: Total hot run time: 31.28 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
github-actions[bot] commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2772232563
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
hello-stephen commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2778961761
# BE UT Coverage Report
Increment line coverage `100.00% (9/9)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/93f7c03cb31466461c4d6d8cad1ad10ba
doris-robot commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2778734214
TPC-DS: Total hot run time: 193195 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2778706702
TPC-H: Total hot run time: 34016 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
morningman commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2778612856
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
doris-robot commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2774874742
TPC-DS: Total hot run time: 193019 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2774888437
ClickBench: Total hot run time: 30.84 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
morningman commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2774741783
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
github-actions[bot] commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2774657876
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
HappenLee commented on code in PR #49082:
URL: https://github.com/apache/doris/pull/49082#discussion_r2024645111
##
be/src/vec/exprs/vexpr.cpp:
##
@@ -371,20 +371,29 @@ Status VExpr::create_tree_from_thrift(const
std::vector& nodes, int*
std::stack> s;
s.emplace(root,
github-actions[bot] commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2772232665
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
doris-robot commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2771928208
# BE UT Coverage Report
Increment line coverage `100.00% (14/14)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/42695318c0ef358fa8ac94e2c843a354f
doris-robot commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2771618373
ClickBench: Total hot run time: 31.56 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
zhangm365 commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2771505990
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
zhangm365 commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2739955124
@morningman pls review the code. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zhangm365 commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2723933166
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
zhangm365 opened a new pull request, #49082:
URL: https://github.com/apache/doris/pull/49082
### What problem does this PR solve?
It will occur the dangling reference to stack top when create the expr tree.
So, the pr changes the logic.
Issue Number: close #xxx
Related PR: #xxx
doris-robot commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2724198926
# BE UT Coverage Report
Increment line coverage `100.00% (13/13)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/cad5c84c725af967ac9b9402b73c275ec
Thearas commented on PR #49082:
URL: https://github.com/apache/doris/pull/49082#issuecomment-2723932832
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
26 matches
Mail list logo
