Re: [PR] [fix](nereids)disable NullSafeEqualToEqual rule [doris]

2024-06-18 Thread via GitHub
starocean999 merged PR #36365: URL: https://github.com/apache/doris/pull/36365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] [fix](nereids)disable NullSafeEqualToEqual rule [doris]

2024-06-17 Thread via GitHub
github-actions[bot] commented on PR #36365: URL: https://github.com/apache/doris/pull/36365#issuecomment-2174934290 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](nereids)disable NullSafeEqualToEqual rule [doris]

2024-06-17 Thread via GitHub
github-actions[bot] commented on PR #36365: URL: https://github.com/apache/doris/pull/36365#issuecomment-2174934268 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](nereids)disable NullSafeEqualToEqual rule [doris]

2024-06-16 Thread via GitHub
doris-robot commented on PR #36365: URL: https://github.com/apache/doris/pull/36365#issuecomment-2172183591 ClickBench: Total hot run time: 31.14 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](nereids)disable NullSafeEqualToEqual rule [doris]

2024-06-16 Thread via GitHub
doris-robot commented on PR #36365: URL: https://github.com/apache/doris/pull/36365#issuecomment-2172179495 TPC-DS: Total hot run time: 174456 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](nereids)disable NullSafeEqualToEqual rule [doris]

2024-06-16 Thread via GitHub
doris-robot commented on PR #36365: URL: https://github.com/apache/doris/pull/36365#issuecomment-2172157852 TPC-H: Total hot run time: 40016 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](nereids)disable NullSafeEqualToEqual rule [doris]

2024-06-16 Thread via GitHub
starocean999 commented on PR #36365: URL: https://github.com/apache/doris/pull/36365#issuecomment-2172084560 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](nereids)disable NullSafeEqualToEqual rule [doris]

2024-06-16 Thread via GitHub
doris-robot commented on PR #36365: URL: https://github.com/apache/doris/pull/36365#issuecomment-2172084497 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](nereids)disable NullSafeEqualToEqual rule [doris]

2024-06-16 Thread via GitHub
starocean999 opened a new pull request, #36365: URL: https://github.com/apache/doris/pull/36365 ## Proposed changes NullSafeEqualToEqual depends on join conjunct's nullable info. But the nullable value may change after this rule. So convert from <=> to = may be wrong. We disable this