Re: [PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
hust-hhb commented on PR #35449: URL: https://github.com/apache/doris/pull/35449#issuecomment-2134451882 after discussion, when be is out of memory, it may not work normally, so in this scenario, just let be core is not a bad idea, so no need to change the code in lookup_row_key, close this

Re: [PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
hust-hhb closed pull request #35449: [fix](mow) add key_bound initialization check when lookup_row_key URL: https://github.com/apache/doris/pull/35449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #35449: URL: https://github.com/apache/doris/pull/35449#issuecomment-2133746128 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
gavinchou commented on PR #35449: URL: https://github.com/apache/doris/pull/35449#issuecomment-213375 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #35449: URL: https://github.com/apache/doris/pull/35449#issuecomment-2133091016 ClickBench: Total hot run time: 29.97 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #35449: URL: https://github.com/apache/doris/pull/35449#issuecomment-2133080519 TPC-DS: Total hot run time: 170793 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #35449: URL: https://github.com/apache/doris/pull/35449#issuecomment-2133058446 TPC-H: Total hot run time: 41091 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #35449: URL: https://github.com/apache/doris/pull/35449#issuecomment-2133012778 TeamCity be ut coverage result: Function Coverage: 35.77% (9009/25187) Line Coverage: 27.40% (74577/272215) Region Coverage: 26.62% (38588/144950) Branch Coverage: 23.4

Re: [PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #35449: URL: https://github.com/apache/doris/pull/35449#issuecomment-2132986735 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
hust-hhb commented on PR #35449: URL: https://github.com/apache/doris/pull/35449#issuecomment-2132975756 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #35449: URL: https://github.com/apache/doris/pull/35449#issuecomment-2132975578 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](mow) add key_bound initialization check when lookup_row_key [doris]

2024-05-27 Thread via GitHub
hust-hhb opened a new pull request, #35449: URL: https://github.com/apache/doris/pull/35449 ## Proposed changes key_bound may be inital failed when be is out of memory, so should add an initialization check before compare key. Issue Number: close #xxx ## Further com