Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-05-31 Thread via GitHub
xinyiZzz closed pull request #33705: [fix](memory) pick fix PODArray swap URL: https://github.com/apache/doris/pull/33705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-16 Thread via GitHub
doris-robot commented on PR #33705: URL: https://github.com/apache/doris/pull/33705#issuecomment-2058560098 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 8e9f921df7714be04328bbea3fefd46f79f5db43 with default session variables Stream

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-16 Thread via GitHub
doris-robot commented on PR #33705: URL: https://github.com/apache/doris/pull/33705#issuecomment-2058554383 ClickBench: Total hot run time: 29.97 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-16 Thread via GitHub
doris-robot commented on PR #33705: URL: https://github.com/apache/doris/pull/33705#issuecomment-2058543725 TPC-DS: Total hot run time: 184066 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-16 Thread via GitHub
doris-robot commented on PR #33705: URL: https://github.com/apache/doris/pull/33705#issuecomment-2058521827 TPC-H: Total hot run time: 38499 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #33705: URL: https://github.com/apache/doris/pull/33705#issuecomment-2058385771 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-16 Thread via GitHub
xinyiZzz commented on PR #33705: URL: https://github.com/apache/doris/pull/33705#issuecomment-2058378636 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-16 Thread via GitHub
xinyiZzz opened a new pull request, #33705: URL: https://github.com/apache/doris/pull/33705 ## Proposed changes pick https://github.com/ClickHouse/ClickHouse/pull/21678 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-16 Thread via GitHub
doris-robot commented on PR #33705: URL: https://github.com/apache/doris/pull/33705#issuecomment-2058378133 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-15 Thread via GitHub
github-actions[bot] commented on code in PR #33698: URL: https://github.com/apache/doris/pull/33698#discussion_r1566779403 ## be/src/vec/common/pod_array.h: ## @@ -420,7 +420,8 @@ class PODArray : public PODArrayBase void emplace_back(Args&&... args) { -if (UNLIKELY

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-15 Thread via GitHub
xinyiZzz commented on PR #33698: URL: https://github.com/apache/doris/pull/33698#issuecomment-2058316568 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-15 Thread via GitHub
github-actions[bot] commented on PR #33698: URL: https://github.com/apache/doris/pull/33698#issuecomment-2058274608 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-15 Thread via GitHub
github-actions[bot] commented on PR #33698: URL: https://github.com/apache/doris/pull/33698#issuecomment-2058272771 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-15 Thread via GitHub
xinyiZzz commented on PR #33698: URL: https://github.com/apache/doris/pull/33698#issuecomment-2058270715 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-15 Thread via GitHub
doris-robot commented on PR #33698: URL: https://github.com/apache/doris/pull/33698#issuecomment-2058268102 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](memory) pick fix PODArray swap [doris]

2024-04-15 Thread via GitHub
xinyiZzz opened a new pull request, #33698: URL: https://github.com/apache/doris/pull/33698 ## Proposed changes pick https://github.com/ClickHouse/ClickHouse/pull/21678 pick https://github.com/ClickHouse/ClickHouse/pull/21533 ## Further comments If this is a relatively