Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-23 Thread via GitHub
xinyiZzz merged PR #36235: URL: https://github.com/apache/doris/pull/36235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-23 Thread via GitHub
github-actions[bot] commented on PR #36235: URL: https://github.com/apache/doris/pull/36235#issuecomment-2185620264 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-23 Thread via GitHub
github-actions[bot] commented on PR #36235: URL: https://github.com/apache/doris/pull/36235#issuecomment-2185620296 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-18 Thread via GitHub
HappenLee commented on code in PR #36235: URL: https://github.com/apache/doris/pull/36235#discussion_r1644643785 ## be/src/runtime/memory/lru_cache_policy.h: ## @@ -208,6 +195,116 @@ class LRUCachePolicy : public CachePolicy { } } +protected: +// if check_cap

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-14 Thread via GitHub
doris-robot commented on PR #36235: URL: https://github.com/apache/doris/pull/36235#issuecomment-2167574678 ClickBench: Total hot run time: 30.72 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-14 Thread via GitHub
doris-robot commented on PR #36235: URL: https://github.com/apache/doris/pull/36235#issuecomment-2167565397 TPC-DS: Total hot run time: 171870 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-14 Thread via GitHub
doris-robot commented on PR #36235: URL: https://github.com/apache/doris/pull/36235#issuecomment-2167566527 TeamCity be ut coverage result: Function Coverage: 36.44% (8985/24654) Line Coverage: 28.03% (73679/262902) Region Coverage: 27.50% (38276/139182) Branch Coverage: 24.2

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-14 Thread via GitHub
doris-robot commented on PR #36235: URL: https://github.com/apache/doris/pull/36235#issuecomment-2167546132 TPC-H: Total hot run time: 39817 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-14 Thread via GitHub
github-actions[bot] commented on PR #36235: URL: https://github.com/apache/doris/pull/36235#issuecomment-2167447786 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-14 Thread via GitHub
xinyiZzz commented on PR #36235: URL: https://github.com/apache/doris/pull/36235#issuecomment-2167435997 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-12 Thread via GitHub
github-actions[bot] commented on PR #36235: URL: https://github.com/apache/doris/pull/36235#issuecomment-2164481302 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-12 Thread via GitHub
xinyiZzz commented on PR #36235: URL: https://github.com/apache/doris/pull/36235#issuecomment-2164460176 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-12 Thread via GitHub
doris-robot commented on PR #36235: URL: https://github.com/apache/doris/pull/36235#issuecomment-2164457648 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](memory) Refactor LRU cache policy memory tracking [doris]

2024-06-12 Thread via GitHub
xinyiZzz opened a new pull request, #36235: URL: https://github.com/apache/doris/pull/36235 ## Proposed changes Fix #35590, CacheManager get CachePolicy should be used lock. - Add LRUCachePolicyTrackingAllocator and LRUCachePolicyTrackingManual. - tracking memory in LRUCachePolic