Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-27 Thread via GitHub
xinyiZzz merged PR #35257: URL: https://github.com/apache/doris/pull/35257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #35257: URL: https://github.com/apache/doris/pull/35257#issuecomment-2132910763 ClickBench: Total hot run time: 30.69 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #35257: URL: https://github.com/apache/doris/pull/35257#issuecomment-2132900597 TPC-DS: Total hot run time: 168263 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #35257: URL: https://github.com/apache/doris/pull/35257#issuecomment-2132879149 TPC-H: Total hot run time: 41333 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-27 Thread via GitHub
doris-robot commented on PR #35257: URL: https://github.com/apache/doris/pull/35257#issuecomment-2132873135 TeamCity be ut coverage result: Function Coverage: 35.76% (9009/25192) Line Coverage: 27.39% (74579/272249) Region Coverage: 26.61% (38575/144962) Branch Coverage: 23.4

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-26 Thread via GitHub
github-actions[bot] commented on PR #35257: URL: https://github.com/apache/doris/pull/35257#issuecomment-2132756089 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-26 Thread via GitHub
github-actions[bot] commented on PR #35257: URL: https://github.com/apache/doris/pull/35257#issuecomment-2132754860 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-26 Thread via GitHub
github-actions[bot] commented on PR #35257: URL: https://github.com/apache/doris/pull/35257#issuecomment-2132754926 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-26 Thread via GitHub
xinyiZzz commented on code in PR #35257: URL: https://github.com/apache/doris/pull/35257#discussion_r1615544169 ## be/src/runtime/memory/thread_mem_tracker_mgr.h: ## @@ -193,7 +198,8 @@ inline void ThreadMemTrackerMgr::consume(int64_t size, int skip_large_memory_che

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-26 Thread via GitHub
xinyiZzz commented on PR #35257: URL: https://github.com/apache/doris/pull/35257#issuecomment-2132748223 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-26 Thread via GitHub
xinyiZzz commented on code in PR #35257: URL: https://github.com/apache/doris/pull/35257#discussion_r1615531946 ## be/src/runtime/memory/thread_mem_tracker_mgr.h: ## @@ -210,6 +216,7 @@ inline void ThreadMemTrackerMgr::consume(int64_t size, int skip_large_memory_che }

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-26 Thread via GitHub
xinyiZzz commented on code in PR #35257: URL: https://github.com/apache/doris/pull/35257#discussion_r1615530570 ## be/src/runtime/memory/thread_mem_tracker_mgr.cpp: ## @@ -44,18 +44,26 @@ class AsyncCancelQueryTask : public Runnable { void ThreadMemTrackerMgr::attach_limiter_tr

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-26 Thread via GitHub
yiguolei commented on code in PR #35257: URL: https://github.com/apache/doris/pull/35257#discussion_r1615458742 ## be/src/runtime/memory/thread_mem_tracker_mgr.h: ## @@ -193,7 +198,8 @@ inline void ThreadMemTrackerMgr::consume(int64_t size, int skip_large_memory_che

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-26 Thread via GitHub
yiguolei commented on code in PR #35257: URL: https://github.com/apache/doris/pull/35257#discussion_r1615435046 ## be/src/runtime/memory/thread_mem_tracker_mgr.h: ## @@ -210,6 +216,7 @@ inline void ThreadMemTrackerMgr::consume(int64_t size, int skip_large_memory_che }

Re: [PR] [fix](memory) Fix nested scoped tracker and nested reserve memory [doris]

2024-05-26 Thread via GitHub
yiguolei commented on code in PR #35257: URL: https://github.com/apache/doris/pull/35257#discussion_r1615428805 ## be/src/runtime/memory/thread_mem_tracker_mgr.cpp: ## @@ -44,18 +44,26 @@ class AsyncCancelQueryTask : public Runnable { void ThreadMemTrackerMgr::attach_limiter_tr