yiguolei merged PR #46405:
URL: https://github.com/apache/doris/pull/46405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apa
github-actions[bot] commented on PR #46405:
URL: https://github.com/apache/doris/pull/46405#issuecomment-2572202435
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #46405:
URL: https://github.com/apache/doris/pull/46405#issuecomment-2572202407
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
cambyzju commented on code in PR #46405:
URL: https://github.com/apache/doris/pull/46405#discussion_r1903604777
##
be/src/vec/functions/function_string.h:
##
@@ -3770,9 +3770,10 @@ class FunctionConvertTo : public IFunction {
auto& res_offset = col_res->get_offsets();
zhangstar333 commented on code in PR #46405:
URL: https://github.com/apache/doris/pull/46405#discussion_r1903555453
##
be/src/vec/functions/function_string.h:
##
@@ -3770,9 +3770,10 @@ class FunctionConvertTo : public IFunction {
auto& res_offset = col_res->get_offsets(
doris-robot commented on PR #46405:
URL: https://github.com/apache/doris/pull/46405#issuecomment-2571591453
TeamCity be ut coverage result:
Function Coverage: 38.88% (10127/26048)
Line Coverage: 29.92% (85700/286410)
Region Coverage: 29.02% (43724/150673)
Branch Coverage: 25.
doris-robot commented on PR #46405:
URL: https://github.com/apache/doris/pull/46405#issuecomment-2571589210
ClickBench: Total hot run time: 31.47 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #46405:
URL: https://github.com/apache/doris/pull/46405#issuecomment-2571587961
TPC-DS: Total hot run time: 190695 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #46405:
URL: https://github.com/apache/doris/pull/46405#issuecomment-2571584870
TPC-H: Total hot run time: 32346 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
cambyzju commented on code in PR #46405:
URL: https://github.com/apache/doris/pull/46405#discussion_r1903242213
##
be/src/clucene:
##
Review Comment:
done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
cambyzju commented on PR #46405:
URL: https://github.com/apache/doris/pull/46405#issuecomment-2571578787
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
superdiaodiao commented on code in PR #46405:
URL: https://github.com/apache/doris/pull/46405#discussion_r1902264109
##
be/src/clucene:
##
Review Comment:
Seems that this file should not be updated in this PR.
--
This is an automated message from the Apache Git Service.
doris-robot commented on PR #46405:
URL: https://github.com/apache/doris/pull/46405#issuecomment-2569352323
TeamCity be ut coverage result:
Function Coverage: 38.88% (10127/26048)
Line Coverage: 29.92% (85701/286405)
Region Coverage: 29.02% (43717/150670)
Branch Coverage: 25.
cambyzju commented on PR #46405:
URL: https://github.com/apache/doris/pull/46405#issuecomment-2569281224
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
Thearas commented on PR #46405:
URL: https://github.com/apache/doris/pull/46405#issuecomment-2569281072
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
cambyzju opened a new pull request, #46405:
URL: https://github.com/apache/doris/pull/46405
### What problem does this PR solve?
Reproduce SQL:
`select convert('装' using gbk);`
Then be crashed:
```
=
16 matches
Mail list logo
