Re: [PR] [fix](function) fix wrong result when convert_tz is out of bound [doris]

2024-07-07 Thread via GitHub
HappenLee commented on code in PR #37358: URL: https://github.com/apache/doris/pull/37358#discussion_r1668048901 ## be/src/vec/functions/function_convert_tz.h: ## @@ -213,6 +207,12 @@ class FunctionConvertTZ : public IFunction { ts_value2.from_unixtime(timestamp, to

Re: [PR] [fix](function) fix wrong result when convert_tz is out of bound [doris]

2024-07-07 Thread via GitHub
zhangstar333 merged PR #37358: URL: https://github.com/apache/doris/pull/37358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] [fix](function) fix wrong result when convert_tz is out of bound [doris]

2024-07-07 Thread via GitHub
github-actions[bot] commented on PR #37358: URL: https://github.com/apache/doris/pull/37358#issuecomment-2212950188 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](function) fix wrong result when convert_tz is out of bound [doris]

2024-07-07 Thread via GitHub
github-actions[bot] commented on PR #37358: URL: https://github.com/apache/doris/pull/37358#issuecomment-2212866428 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](function) fix wrong result when convert_tz is out of bound [doris]

2024-07-05 Thread via GitHub
doris-robot commented on PR #37358: URL: https://github.com/apache/doris/pull/37358#issuecomment-2210925648 ClickBench: Total hot run time: 31.03 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](function) fix wrong result when convert_tz is out of bound [doris]

2024-07-05 Thread via GitHub
doris-robot commented on PR #37358: URL: https://github.com/apache/doris/pull/37358#issuecomment-2210915952 TPC-DS: Total hot run time: 172666 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](function) fix wrong result when convert_tz is out of bound [doris]

2024-07-05 Thread via GitHub
doris-robot commented on PR #37358: URL: https://github.com/apache/doris/pull/37358#issuecomment-2210898008 TPC-H: Total hot run time: 39687 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](function) fix wrong result when convert_tz is out of bound [doris]

2024-07-05 Thread via GitHub
github-actions[bot] commented on code in PR #37358: URL: https://github.com/apache/doris/pull/37358#discussion_r1666802017 ## be/src/vec/functions/function_convert_tz.h: ## @@ -18,19 +18,15 @@ #pragma once #include Review Comment: warning: 'cctz/time_zone.h' file not fo

Re: [PR] [fix](function) fix wrong result when convert_tz is out of bound [doris]

2024-07-05 Thread via GitHub
zclllyybb commented on PR #37358: URL: https://github.com/apache/doris/pull/37358#issuecomment-2210859044 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](function) fix wrong result when convert_tz is out of bound [doris]

2024-07-05 Thread via GitHub
doris-robot commented on PR #37358: URL: https://github.com/apache/doris/pull/37358#issuecomment-2210859006 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](function) fix wrong result when convert_tz is out of bound [doris]

2024-07-05 Thread via GitHub
zclllyybb opened a new pull request, #37358: URL: https://github.com/apache/doris/pull/37358 ## Proposed changes Issue Number: close #xxx before: ```sql mysql> select CONVERT_TZ(cast('-01-01 00:00:00.1' as DATETIMEV1), cast('Asia/Shanghai' as VARCHAR(65533)), cas