xy720 commented on code in PR #31312:
URL: https://github.com/apache/doris/pull/31312#discussion_r1504019968
##
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##
@@ -495,6 +495,12 @@ public static boolean isCastMatchAllowed(Function desc,
Function candicate
xy720 commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1966251508
> @zclllyybb @xy720 . Cast `string` to `array` is ok. We parse it with json
format. `string` `'[1,2,3]'` cast to `array` will produce text array
with 3 elements: `'1'`, `'2'` and `'3'`. It
morrySnow commented on code in PR #31312:
URL: https://github.com/apache/doris/pull/31312#discussion_r1502507315
##
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##
@@ -495,6 +495,12 @@ public static boolean isCastMatchAllowed(Function desc,
Function candi
morrySnow commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1963835069
cast `string` to `array` is ok, we parse it as json. string `'[1,2,3]'` cast
to `array` will produce text array with 3 elements: `'1'`, `'2'` and
`'3'`. It is not ambiguous. All strings
xy720 commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1963663454
> > > > > need more discuss. hold on now. we may need a complete fix on
planner to prohibit `string` to `array`. @morrySnow PTAL
> > > >
> > > >
> > > > @zclllyybb @morrySnow Do w
zclllyybb commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1963602141
> > > > need more discuss. hold on now. we may need a complete fix on
planner to prohibit `string` to `array`. @morrySnow PTAL
> > >
> > >
> > > @zclllyybb @morrySnow Do we st
xy720 merged PR #31312:
URL: https://github.com/apache/doris/pull/31312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache
xy720 commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1963530765
> > > need more discuss. hold on now. we may need a complete fix on planner
to prohibit `string` to `array`. @morrySnow PTAL
> >
> >
> > @zclllyybb @morrySnow Do we still need to
zclllyybb commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1963490462
> > need more discuss. hold on now. we may need a complete fix on planner to
prohibit `string` to `array`. @morrySnow PTAL
>
> @zclllyybb @morrySnow Do we still need to discuss it
xy720 commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1963469829
> need more discuss. hold on now. we may need a complete fix on planner to
prohibit `string` to `array`. @morrySnow PTAL
@zclllyybb @morrySnow Do we still need to discuss it? Perhaps
zhiqiang- commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1963256866
Signature of this function in doris suggests that the result is always not
nullable, if we changed that, there will be many changes on BE, for example
maybe we should set `use_defau
xy720 commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1963243218
> Do we need to throw exception when we meeting NULL as argument ?
For this type of case, CK will return nil instead of throwing an error, and
Doris are currently returning 0. Do we n
xy720 commented on code in PR #31312:
URL: https://github.com/apache/doris/pull/31312#discussion_r1501994009
##
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##
@@ -495,6 +495,12 @@ public static boolean isCastMatchAllowed(Function desc,
Function candicate
xy720 commented on code in PR #31312:
URL: https://github.com/apache/doris/pull/31312#discussion_r1501994009
##
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##
@@ -495,6 +495,12 @@ public static boolean isCastMatchAllowed(Function desc,
Function candicate
zclllyybb commented on code in PR #31312:
URL: https://github.com/apache/doris/pull/31312#discussion_r1501363784
##
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##
@@ -495,6 +495,12 @@ public static boolean isCastMatchAllowed(Function desc,
Function candi
zhiqiang- commented on code in PR #31312:
URL: https://github.com/apache/doris/pull/31312#discussion_r1501352897
##
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##
@@ -495,6 +495,12 @@ public static boolean isCastMatchAllowed(Function desc,
Function c
doris-robot commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1961397734
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit acbf68f97b059210c9db3f42651a7fddb6b3a367 with
default session variables
Stream
doris-robot commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1961392930
ClickBench: Total hot run time: 31.35 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1961383802
TPC-DS: Total hot run time: 175568 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1961365753
TPC-H: Total hot run time: 40756 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1961363543
TeamCity be ut coverage result:
Function Coverage: 35.71% (8548/23937)
Line Coverage: 27.52% (69361/251995)
Region Coverage: 26.68% (35971/134848)
Branch Coverage: 23.4
github-actions[bot] commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1961354412
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1961354335
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
xy720 commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1961318727
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
doris-robot commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1960790546
TeamCity be ut coverage result:
Function Coverage: 35.71% (8547/23936)
Line Coverage: 27.53% (69360/251944)
Region Coverage: 26.68% (35976/134843)
Branch Coverage: 23.4
github-actions[bot] commented on code in PR #31312:
URL: https://github.com/apache/doris/pull/31312#discussion_r1500238642
##
be/src/vec/functions/functions_multi_string_position.cpp:
##
@@ -110,6 +106,11 @@ class FunctionMultiStringPosition : public IFunction {
const C
github-actions[bot] commented on code in PR #31312:
URL: https://github.com/apache/doris/pull/31312#discussion_r1500236990
##
be/src/vec/functions/functions_multi_string_position.cpp:
##
@@ -110,6 +106,11 @@ class FunctionMultiStringPosition : public IFunction {
const C
xy720 commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1960767237
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
doris-robot commented on PR #31312:
URL: https://github.com/apache/doris/pull/31312#issuecomment-1960764407
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
xy720 opened a new pull request, #31312:
URL: https://github.com/apache/doris/pull/31312
## Proposed changes
Issue Number: close #31311
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:
30 matches
Mail list logo
