Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-18 Thread via GitHub
HappenLee merged PR #40710: URL: https://github.com/apache/doris/pull/40710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357468046 TeamCity be ut coverage result: Function Coverage: 37.32% (9575/25655) Line Coverage: 28.70% (79117/275704) Region Coverage: 28.18% (40979/145402) Branch Coverage: 24.8

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357458453 ClickBench: Total hot run time: 32.86 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357453874 TPC-DS: Total hot run time: 194326 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
github-actions[bot] commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357445608 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
github-actions[bot] commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357445576 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357442787 TPC-H: Total hot run time: 41673 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
Mryange commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357386413 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357383575 ClickBench: Total hot run time: 32.46 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357379170 TPC-DS: Total hot run time: 199234 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357368052 TPC-H: Total hot run time: 41605 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357353972 TeamCity be ut coverage result: Function Coverage: 37.33% (9576/25655) Line Coverage: 28.71% (79145/275681) Region Coverage: 28.18% (40975/145386) Branch Coverage: 24.8

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
Mryange commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2357322263 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-17 Thread via GitHub
HappenLee commented on code in PR #40710: URL: https://github.com/apache/doris/pull/40710#discussion_r1764258585 ## be/src/vec/functions/function_string.h: ## @@ -2251,6 +2221,34 @@ class FunctionSplitByString : public IFunction { } return pos - old_size;

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-13 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2350836094 ClickBench: Total hot run time: 30.95 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-13 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2350834883 TPC-DS: Total hot run time: 199937 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-13 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2350832092 TPC-H: Total hot run time: 42634 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-13 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2350828517 TeamCity be ut coverage result: Function Coverage: 36.91% (9473/25664) Line Coverage: 28.28% (77902/275482) Region Coverage: 27.68% (40228/145323) Branch Coverage: 24.2

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-13 Thread via GitHub
Mryange commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2350820051 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2345215462 ClickBench: Total hot run time: 31.18 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2345210728 TPC-DS: Total hot run time: 194681 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2345205559 TeamCity be ut coverage result: Function Coverage: 36.89% (9454/25630) Line Coverage: 28.24% (77753/275289) Region Coverage: 27.65% (40146/145193) Branch Coverage: 24.2

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2345200836 TPC-H: Total hot run time: 40195 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-11 Thread via GitHub
Mryange commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2345182939 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-11 Thread via GitHub
doris-robot commented on PR #40710: URL: https://github.com/apache/doris/pull/40710#issuecomment-2345182799 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](function) fix error result in split_by_string with utf8 chars [doris]

2024-09-11 Thread via GitHub
Mryange opened a new pull request, #40710: URL: https://github.com/apache/doris/pull/40710 ## Proposed changes ``` mysql []>select split_by_string('你a好b世c界',''); +-+ | split_by_string('你a好b世c界', '')