github-actions[bot] commented on code in PR #35883:
URL: https://github.com/apache/doris/pull/35883#discussion_r1628972550
##
be/src/vec/runtime/vdatetime_value.cpp:
##
@@ -3435,10 +3441,13 @@
}
template
-bool DateV2Value::to_format_string(const char* format, int len, char*
zclllyybb commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2151647652
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
HappenLee commented on code in PR #35883:
URL: https://github.com/apache/doris/pull/35883#discussion_r1628877629
##
be/src/vec/runtime/vdatetime_value.cpp:
##
@@ -3421,10 +3519,12 @@ void DateV2Value::set_microsecond(uint32_t
microsecond) {
}
template
-bool DateV2Value::to
HappenLee commented on code in PR #35883:
URL: https://github.com/apache/doris/pull/35883#discussion_r1628817142
##
be/src/olap/types.h:
##
@@ -1240,7 +1240,7 @@ struct FieldTypeTraits
string res;
res.resize(12);
Review Comment:
why here call reize and rese
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2150144426
ClickBench: Total hot run time: 30.53 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2150121926
TPC-DS: Total hot run time: 171704 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2150077445
TPC-H: Total hot run time: 41385 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2150043026
TeamCity be ut coverage result:
Function Coverage: 36.38% (8985/24696)
Line Coverage: 27.91% (73458/263174)
Region Coverage: 27.37% (38096/139192)
Branch Coverage: 23.9
zclllyybb commented on code in PR #35883:
URL: https://github.com/apache/doris/pull/35883#discussion_r1627674841
##
be/src/vec/runtime/vdatetime_value.h:
##
@@ -822,7 +823,8 @@ class DateV2Value {
return val;
}
-bool to_format_string(const char* format, int l
zclllyybb commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2149723575
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2149642288
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
zhiqiang- commented on code in PR #35883:
URL: https://github.com/apache/doris/pull/35883#discussion_r1627606425
##
be/src/vec/runtime/vdatetime_value.h:
##
@@ -822,7 +823,8 @@ class DateV2Value {
return val;
}
-bool to_format_string(const char* format, i
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2148979550
ClickBench: Total hot run time: 30.45 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2148972487
TPC-DS: Total hot run time: 173175 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2148958677
TeamCity be ut coverage result:
Function Coverage: 36.41% (8985/24675)
Line Coverage: 27.93% (73433/262952)
Region Coverage: 27.39% (38090/139059)
Branch Coverage: 23.9
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2148958129
TPC-H: Total hot run time: 41794 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on code in PR #35883:
URL: https://github.com/apache/doris/pull/35883#discussion_r1626938867
##
be/src/vec/runtime/vdatetime_value.cpp:
##
@@ -673,10 +672,12 @@ char* write_four_digits_to_string(int number, char* dst) {
return dst + 4;
}
-bo
zclllyybb commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2148842600
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2148577445
ClickBench: Total hot run time: 31.59 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2148573012
TPC-DS: Total hot run time: 168908 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2148564330
TPC-H: Total hot run time: 41096 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on code in PR #35883:
URL: https://github.com/apache/doris/pull/35883#discussion_r1626646488
##
be/src/vec/runtime/vdatetime_value.cpp:
##
@@ -3421,10 +3519,12 @@
}
template
-bool DateV2Value::to_format_string(const char* format, int len, char*
doris-robot commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2148470987
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
zclllyybb commented on PR #35883:
URL: https://github.com/apache/doris/pull/35883#issuecomment-2148471029
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
zclllyybb opened a new pull request, #35883:
URL: https://github.com/apache/doris/pull/35883
## Proposed changes
Issue Number: close #xxx
```sql
SELECT DATE_FORMAT('2011-06-24', '%f %V %f %l %V %I %S %p %w %r %j %f %l %I
%D %w %j %D %e %s %V %f %D %M %s %X %U %v %c %u %x %r
25 matches
Mail list logo