Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-26 Thread via GitHub
eldenmoon merged PR #39699: URL: https://github.com/apache/doris/pull/39699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-26 Thread via GitHub
github-actions[bot] commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2311700044 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-26 Thread via GitHub
github-actions[bot] commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2311700097 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-23 Thread via GitHub
doris-robot commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2306672944 ClickBench: Total hot run time: 31.05 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-23 Thread via GitHub
doris-robot commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2306662593 TPC-DS: Total hot run time: 191859 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-23 Thread via GitHub
doris-robot commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2306640855 TPC-H: Total hot run time: 38441 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-23 Thread via GitHub
github-actions[bot] commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2306502085 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-23 Thread via GitHub
amorynan commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2306490390 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-21 Thread via GitHub
doris-robot commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2301498712 ClickBench: Total hot run time: 30.61 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-21 Thread via GitHub
doris-robot commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2301487666 TPC-DS: Total hot run time: 196642 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-21 Thread via GitHub
doris-robot commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2301459160 TPC-H: Total hot run time: 38465 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-21 Thread via GitHub
github-actions[bot] commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2301313469 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-21 Thread via GitHub
amorynan commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2301300555 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-20 Thread via GitHub
github-actions[bot] commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2301257269 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-20 Thread via GitHub
github-actions[bot] commented on code in PR #39699: URL: https://github.com/apache/doris/pull/39699#discussion_r1724480766 ## be/src/vec/functions/function.h: ## @@ -388,6 +388,7 @@ class IFunction : public std::enable_shared_from_this, public: String get_name() const ove

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-20 Thread via GitHub
amorynan commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2301246849 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](funcs) map struct construct funcs [doris]

2024-08-20 Thread via GitHub
doris-robot commented on PR #39699: URL: https://github.com/apache/doris/pull/39699#issuecomment-2301243539 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](funcs) map struct construct funcs [doris]

2024-08-20 Thread via GitHub
amorynan opened a new pull request, #39699: URL: https://github.com/apache/doris/pull/39699 ## Proposed changes we should not change the column which is passed from a block when we execute a function , because this block may be used in other expression or other exec node Issue Number: