Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-17 Thread via GitHub
caizj commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2062882321 This PR makes [BE UT (macOS)] fail: [BE UT (macOS)](https://github.com/apache/doris/actions/runs/8720549173/job/23926149116?pr=33792#logs): /Users/runner/work/doris/doris/be/src/io

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-17 Thread via GitHub
dataroaring merged PR #33680: URL: https://github.com/apache/doris/pull/33680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2060683511 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2060683429 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-16 Thread via GitHub
doris-robot commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2059518019 TPC-H: Total hot run time: 38488 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-16 Thread via GitHub
doris-robot commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2059498484 TeamCity be ut coverage result: Function Coverage: 35.50% (8908/25092) Line Coverage: 27.22% (73165/268745) Region Coverage: 26.35% (37826/143555) Branch Coverage: 23.1

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2059449428 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-16 Thread via GitHub
platoneko commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2059444254 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-16 Thread via GitHub
gavinchou commented on code in PR #33680: URL: https://github.com/apache/doris/pull/33680#discussion_r1567299080 ## be/src/io/fs/hdfs_file_writer.cpp: ## @@ -53,23 +58,29 @@ Status HdfsFileWriter::close() { return Status::OK(); } _closed = true; -int resul

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-16 Thread via GitHub
doris-robot commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2058559060 TeamCity be ut coverage result: Function Coverage: 35.50% (8905/25083) Line Coverage: 27.23% (73143/268650) Region Coverage: 26.35% (37816/143518) Branch Coverage: 23.1

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2058521449 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-16 Thread via GitHub
platoneko commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2058511602 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-15 Thread via GitHub
doris-robot commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2058222475 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit d03f811cf4901205940abc660e156c68167ccb74 with default session variables Stream

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-15 Thread via GitHub
doris-robot commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2058220138 ClickBench: Total hot run time: 31.27 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-15 Thread via GitHub
doris-robot commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2058216035 TPC-DS: Total hot run time: 184193 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-15 Thread via GitHub
doris-robot commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2058207526 TPC-H: Total hot run time: 38366 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-15 Thread via GitHub
doris-robot commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2058205038 TeamCity be ut coverage result: Function Coverage: 35.55% (8904/25046) Line Coverage: 27.28% (73135/268108) Region Coverage: 26.40% (37824/143255) Branch Coverage: 23.1

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-15 Thread via GitHub
dataroaring commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2058182993 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-15 Thread via GitHub
github-actions[bot] commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2058173138 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-15 Thread via GitHub
dataroaring commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2057054447 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-15 Thread via GitHub
github-actions[bot] commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2056736433 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-15 Thread via GitHub
platoneko opened a new pull request, #33680: URL: https://github.com/apache/doris/pull/33680 ## Proposed changes Fix hdfs file writer ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris

Re: [PR] [fix](fs) Fix hdfs file writer [doris]

2024-04-15 Thread via GitHub
doris-robot commented on PR #33680: URL: https://github.com/apache/doris/pull/33680#issuecomment-2056725369 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y