Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-25 Thread via GitHub
morningman merged PR #31355: URL: https://github.com/apache/doris/pull/31355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-23 Thread via GitHub
doris-robot commented on PR #31355: URL: https://github.com/apache/doris/pull/31355#issuecomment-1961691926 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit c3748fd7ff8c75d51657280656436fa9158cc74a with default session variables Stream

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-23 Thread via GitHub
doris-robot commented on PR #31355: URL: https://github.com/apache/doris/pull/31355#issuecomment-1961687059 ClickBench: Total hot run time: 31.22 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-23 Thread via GitHub
doris-robot commented on PR #31355: URL: https://github.com/apache/doris/pull/31355#issuecomment-1961678443 TPC-DS: Total hot run time: 202047 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-23 Thread via GitHub
doris-robot commented on PR #31355: URL: https://github.com/apache/doris/pull/31355#issuecomment-1961659735 TPC-H: Total hot run time: 50125 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-23 Thread via GitHub
doris-robot commented on PR #31355: URL: https://github.com/apache/doris/pull/31355#issuecomment-1961658994 TeamCity be ut coverage result: Function Coverage: 37.80% (8035/21255) Line Coverage: 29.48% (65533/67) Region Coverage: 28.94% (33709/116471) Branch Coverage: 24.8

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-23 Thread via GitHub
morningman commented on PR #31355: URL: https://github.com/apache/doris/pull/31355#issuecomment-1961607489 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-23 Thread via GitHub
morningman commented on PR #31355: URL: https://github.com/apache/doris/pull/31355#issuecomment-1961574278 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-23 Thread via GitHub
github-actions[bot] commented on code in PR #31355: URL: https://github.com/apache/doris/pull/31355#discussion_r1500815983 ## be/src/io/fs/file_writer_options.h: ## @@ -26,6 +26,8 @@ struct FileWriterOptions { bool is_cold_data = false; bool sync_file_data = true;

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-23 Thread via GitHub
doris-robot commented on PR #31355: URL: https://github.com/apache/doris/pull/31355#issuecomment-1961506774 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-23 Thread via GitHub
morningman opened a new pull request, #31355: URL: https://github.com/apache/doris/pull/31355 bp #31169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-20 Thread via GitHub
dataroaring merged PR #31169: URL: https://github.com/apache/doris/pull/31169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #31169: URL: https://github.com/apache/doris/pull/31169#issuecomment-1954356071 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-20 Thread via GitHub
doris-robot commented on PR #31169: URL: https://github.com/apache/doris/pull/31169#issuecomment-1954304942 TeamCity be ut coverage result: Function Coverage: 35.77% (8558/23927) Line Coverage: 27.72% (69425/250430) Region Coverage: 26.83% (36022/134243) Branch Coverage: 23.6

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-20 Thread via GitHub
gavinchou commented on PR #31169: URL: https://github.com/apache/doris/pull/31169#issuecomment-1954225857 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #31169: URL: https://github.com/apache/doris/pull/31169#issuecomment-1954126122 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #31169: URL: https://github.com/apache/doris/pull/31169#issuecomment-1954037513 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #31169: URL: https://github.com/apache/doris/pull/31169#issuecomment-1954032546 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-20 Thread via GitHub
github-actions[bot] commented on PR #31169: URL: https://github.com/apache/doris/pull/31169#issuecomment-1954030681 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-20 Thread via GitHub
doris-robot commented on PR #31169: URL: https://github.com/apache/doris/pull/31169#issuecomment-1954013893 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](file-writer) avoid empty file for segment writer [doris]

2024-02-20 Thread via GitHub
morningman opened a new pull request, #31169: URL: https://github.com/apache/doris/pull/31169 ## Proposed changes This #30703 allow writing empty file. But internal segment file do not allow empty file. So I add a new FileWriterOption `create_empty_file` to indicate whether to