Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-22 Thread via GitHub
yiguolei merged PR #45655: URL: https://github.com/apache/doris/pull/45655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-22 Thread via GitHub
yiguolei merged PR #45662: URL: https://github.com/apache/doris/pull/45662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
doris-robot commented on PR #45662: URL: https://github.com/apache/doris/pull/45662#issuecomment-2553733390 TeamCity be ut coverage result: Function Coverage: 36.46% (9569/26244) Line Coverage: 27.92% (78656/281683) Region Coverage: 26.60% (40383/151817) Branch Coverage: 23.3

Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
Mryange commented on PR #45662: URL: https://github.com/apache/doris/pull/45662#issuecomment-2553518728 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
github-actions[bot] commented on code in PR #45662: URL: https://github.com/apache/doris/pull/45662#discussion_r1891667970 ## be/src/vec/exprs/vcompound_pred.h: ## @@ -144,15 +144,13 @@ class VCompoundPred : public VectorizedFnCall { } if (all_pass && !res.is

Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
Mryange commented on PR #45662: URL: https://github.com/apache/doris/pull/45662#issuecomment-2553472647 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
Mryange opened a new pull request, #45662: URL: https://github.com/apache/doris/pull/45662 https://github.com/apache/doris/pull/45655 In the past, a _can_fast_execute flag was maintained in VExpr. However, since exec executes concurrently, errors would occur when using the _can_fast_exec

Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
hello-stephen commented on PR #45662: URL: https://github.com/apache/doris/pull/45662#issuecomment-2553472353 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro

Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
doris-robot commented on PR #45655: URL: https://github.com/apache/doris/pull/45655#issuecomment-2553469967 TPC-DS: Total hot run time: 195018 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
doris-robot commented on PR #45655: URL: https://github.com/apache/doris/pull/45655#issuecomment-2553446469 TPC-H: Total hot run time: 40511 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
github-actions[bot] commented on code in PR #45655: URL: https://github.com/apache/doris/pull/45655#discussion_r1891559534 ## be/src/vec/exprs/vcompound_pred.h: ## @@ -144,15 +144,13 @@ class VCompoundPred : public VectorizedFnCall { } if (all_pass && !res.is

Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
Mryange commented on PR #45655: URL: https://github.com/apache/doris/pull/45655#issuecomment-2553316383 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
hello-stephen commented on PR #45655: URL: https://github.com/apache/doris/pull/45655#issuecomment-2553315947 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro

[PR] [fix](expr)Remove the _can_fast_execute flag from VExpr. (#45542) [doris]

2024-12-19 Thread via GitHub
Mryange opened a new pull request, #45655: URL: https://github.com/apache/doris/pull/45655 https://github.com/apache/doris/pull/45542 In the past, a _can_fast_execute flag was maintained in VExpr. However, since exec executes concurrently, errors would occur when using the _can_fast_exec