Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
Gabriel39 merged PR #35121: URL: https://github.com/apache/doris/pull/35121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2123808925 TeamCity be ut coverage result: Function Coverage: 35.68% (9015/25268) Line Coverage: 27.31% (74515/272891) Region Coverage: 26.54% (38562/145295) Branch Coverage: 23.3

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2123808832 ClickBench: Total hot run time: 31.03 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2123805136 TPC-DS: Total hot run time: 181135 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2123797319 TPC-H: Total hot run time: 41922 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2123748221 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
Gabriel39 commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2123744462 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2123714701 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2122806675 ClickBench: Total hot run time: 30.41 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2122795122 TPC-DS: Total hot run time: 181283 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2122770526 TPC-H: Total hot run time: 40472 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
Gabriel39 commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2122654287 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2122355590 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2122355518 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-214170 ClickBench: Total hot run time: 30.45 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2122213650 TPC-DS: Total hot run time: 182636 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
Gabriel39 commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2122035115 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on code in PR #35121: URL: https://github.com/apache/doris/pull/35121#discussion_r1607768344 ## be/src/util/string_parser.hpp: ## @@ -594,123 +594,74 @@ T StringParser::string_to_decimal(const char* __restrict s, int len, int type_pr bool foun

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35121: URL: https://github.com/apache/doris/pull/35121#issuecomment-2121914648 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-21 Thread via GitHub
Gabriel39 opened a new pull request, #35121: URL: https://github.com/apache/doris/pull/35121 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt