gavinchou merged PR #46561:
URL: https://github.com/apache/doris/pull/46561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.ap
freemandealer commented on code in PR #46561:
URL: https://github.com/apache/doris/pull/46561#discussion_r1923048659
##
be/src/io/cache/block_file_cache.cpp:
##
@@ -1789,9 +1718,41 @@ void BlockFileCache::run_background_operation() {
if (cur_time < begin->first)
freemandealer commented on code in PR #46561:
URL: https://github.com/apache/doris/pull/46561#discussion_r1923048659
##
be/src/io/cache/block_file_cache.cpp:
##
@@ -1789,9 +1718,41 @@ void BlockFileCache::run_background_operation() {
if (cur_time < begin->first)
freemandealer commented on code in PR #46561:
URL: https://github.com/apache/doris/pull/46561#discussion_r1923048659
##
be/src/io/cache/block_file_cache.cpp:
##
@@ -1789,9 +1718,41 @@ void BlockFileCache::run_background_operation() {
if (cur_time < begin->first)
freemandealer commented on code in PR #46561:
URL: https://github.com/apache/doris/pull/46561#discussion_r1922981585
##
be/src/io/cache/block_file_cache.cpp:
##
@@ -1789,9 +1718,41 @@ void BlockFileCache::run_background_operation() {
if (cur_time < begin->first)
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2597302380
ClickBench: Total hot run time: 30.03 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2597297222
TPC-DS: Total hot run time: 193427 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2597285549
TPC-H: Total hot run time: 32215 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2597262995
run performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2597262882
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2596387537
TeamCity be ut coverage result:
Function Coverage: 41.53% (10819/26054)
Line Coverage: 31.91% (91379/286347)
Region Coverage: 31.06% (46817/150745)
Branch Coverage: 27.
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2596270694
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2592701090
ClickBench: Total hot run time: 30.66 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2592680780
TPC-DS: Total hot run time: 194278 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2592653964
TeamCity be ut coverage result:
Function Coverage: 41.02% (10687/26054)
Line Coverage: 31.52% (90264/286361)
Region Coverage: 30.67% (46243/150757)
Branch Coverage: 26.
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2592635861
TPC-H: Total hot run time: 32500 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2592464936
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2592163373
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2592057176
ClickBench: Total hot run time: 30.94 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2592039732
TPC-DS: Total hot run time: 195710 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591985290
TPC-H: Total hot run time: 33160 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591982233
TeamCity be ut coverage result:
Function Coverage: 41.02% (10687/26054)
Line Coverage: 31.52% (90269/286361)
Region Coverage: 30.68% (46246/150757)
Branch Coverage: 26.
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591847117
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591731888
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591731858
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591642881
TeamCity be ut coverage result:
Function Coverage: 41.02% (10688/26054)
Line Coverage: 31.52% (90262/286335)
Region Coverage: 30.68% (46243/150744)
Branch Coverage: 26.
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591638114
ClickBench: Total hot run time: 31.43 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591632812
TPC-DS: Total hot run time: 194958 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591620491
TPC-H: Total hot run time: 33081 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591569990
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591529235
TeamCity be ut coverage result:
Function Coverage: 40.56% (10569/26057)
Line Coverage: 31.23% (89430/286325)
Region Coverage: 30.35% (45744/150715)
Branch Coverage: 26.
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591523174
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591519750
ClickBench: Total hot run time: 31.04 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591514427
TPC-DS: Total hot run time: 188509 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591500638
TPC-H: Total hot run time: 32501 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2591475200
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2590777637
ClickBench: Total hot run time: 31.43 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2590767809
TPC-DS: Total hot run time: 195071 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2590740385
TPC-H: Total hot run time: 32917 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2590404072
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2588810560
ClickBench: Total hot run time: 31.63 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2588800260
TPC-DS: Total hot run time: 195635 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
freemandealer commented on PR #46404:
URL: https://github.com/apache/doris/pull/46404#issuecomment-2588775830
updated in new PR: https://github.com/apache/doris/pull/46561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
freemandealer closed pull request #46404: [fix](cloud) fix file cache potential
leakage
URL: https://github.com/apache/doris/pull/46404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2588771241
TPC-H: Total hot run time: 32961 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2588562668
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2588547411
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2587539211
run beut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
freemandealer commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2587539421
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2583301188
ClickBench: Total hot run time: 31.05 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2583292076
TPC-DS: Total hot run time: 196353 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #46561:
URL: https://github.com/apache/doris/pull/46561#issuecomment-2583271296
TPC-H: Total hot run time: 32575 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
gavinchou commented on code in PR #46404:
URL: https://github.com/apache/doris/pull/46404#discussion_r1901904553
##
be/src/io/cache/block_file_cache.cpp:
##
@@ -562,7 +561,7 @@ std::string BlockFileCache::clear_file_cache_async() {
void BlockFileCache::recycle_deleted_blocks(
gavinchou commented on code in PR #46404:
URL: https://github.com/apache/doris/pull/46404#discussion_r1901889847
##
be/src/io/cache/block_file_cache.cpp:
##
@@ -562,7 +561,7 @@ std::string BlockFileCache::clear_file_cache_async() {
void BlockFileCache::recycle_deleted_blocks(
gavinchou commented on code in PR #46404:
URL: https://github.com/apache/doris/pull/46404#discussion_r1901888105
##
be/src/io/cache/block_file_cache.cpp:
##
@@ -573,45 +572,34 @@ void BlockFileCache::recycle_deleted_blocks() {
int i = 0;
std::condition_variable cond;
gavinchou commented on code in PR #46404:
URL: https://github.com/apache/doris/pull/46404#discussion_r1901884987
##
be/src/io/cache/block_file_cache.cpp:
##
@@ -630,14 +618,11 @@ void BlockFileCache::recycle_deleted_blocks() {
cell.is_deleted =
freemandealer commented on PR #46404:
URL: https://github.com/apache/doris/pull/46404#issuecomment-2569284855
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
hello-stephen commented on PR #46404:
URL: https://github.com/apache/doris/pull/46404#issuecomment-2569274864
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro
freemandealer opened a new pull request, #46404:
URL: https://github.com/apache/doris/pull/46404
1. fix compaction gc leakage by correcting use_count() of rowset shr_ptr
2. seperate monitoring and gc routine in blockfilecache backgroud thread to
avoid interference
3. update BlockFileCa
59 matches
Mail list logo
