Re: [PR] [fix](build) Building Failed on x86 Mac [doris]

2024-12-18 Thread via GitHub
github-actions[bot] commented on PR #45613: URL: https://github.com/apache/doris/pull/45613#issuecomment-2551329459 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](build) Building Failed on x86 Mac [doris]

2024-12-18 Thread via GitHub
github-actions[bot] commented on code in PR #45613: URL: https://github.com/apache/doris/pull/45613#discussion_r1890237537 ## be/src/http/http_channel.cpp: ## @@ -25,6 +25,7 @@ #include #include #include +#include Review Comment: warning: inclusion of deprecated C++ h

Re: [PR] [fix](build) Building Failed on x86 Mac [doris]

2024-12-18 Thread via GitHub
github-actions[bot] commented on code in PR #45613: URL: https://github.com/apache/doris/pull/45613#discussion_r1890232558 ## be/src/http/http_channel.cpp: ## @@ -25,6 +25,7 @@ #include #include #include +#include Review Comment: warning: inclusion of deprecated C++ h

Re: [PR] [fix](build) Building Failed on x86 Mac [doris]

2024-12-18 Thread via GitHub
github-actions[bot] commented on PR #45613: URL: https://github.com/apache/doris/pull/45613#issuecomment-2551304339 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/12393798062";) output. shellcheck er

[PR] [fix](build) Building Failed on x86 Mac [doris]

2024-12-18 Thread via GitHub
coldWeather66260 opened a new pull request, #45613: URL: https://github.com/apache/doris/pull/45613 ### What problem does this PR solve? Problem Summary: 1. `build-thirdparty.sh` doesn't cover x86 Mac when renaming symbols for bitshuffle AVX2. 2. `http_channel.cpp` uses `%l

Re: [PR] [fix](build) Building Failed on x86 Mac [doris]

2024-12-18 Thread via GitHub
hello-stephen commented on PR #45613: URL: https://github.com/apache/doris/pull/45613#issuecomment-2551302713 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro