Re: [PR] [fix](binlog) Avoid clear binlog dir [doris]

2024-12-17 Thread via GitHub
w41ter merged PR #45581: URL: https://github.com/apache/doris/pull/45581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apach

Re: [PR] [fix](binlog) Avoid clear binlog dir [doris]

2024-12-17 Thread via GitHub
doris-robot commented on PR #45581: URL: https://github.com/apache/doris/pull/45581#issuecomment-2550418107 ClickBench: Total hot run time: 33.36 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](binlog) Avoid clear binlog dir [doris]

2024-12-17 Thread via GitHub
doris-robot commented on PR #45581: URL: https://github.com/apache/doris/pull/45581#issuecomment-2550411841 TPC-DS: Total hot run time: 196996 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](binlog) Avoid clear binlog dir [doris]

2024-12-17 Thread via GitHub
doris-robot commented on PR #45581: URL: https://github.com/apache/doris/pull/45581#issuecomment-2550390948 TPC-H: Total hot run time: 39649 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](binlog) Avoid clear binlog dir [doris]

2024-12-17 Thread via GitHub
github-actions[bot] commented on PR #45581: URL: https://github.com/apache/doris/pull/45581#issuecomment-2550344337 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](binlog) Avoid clear binlog dir [doris]

2024-12-17 Thread via GitHub
github-actions[bot] commented on PR #45581: URL: https://github.com/apache/doris/pull/45581#issuecomment-2550344295 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](binlog) Avoid clear binlog dir [doris]

2024-12-17 Thread via GitHub
dataroaring commented on PR #45581: URL: https://github.com/apache/doris/pull/45581#issuecomment-2550344059 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](binlog) Avoid clear binlog dir [doris]

2024-12-17 Thread via GitHub
github-actions[bot] commented on code in PR #45581: URL: https://github.com/apache/doris/pull/45581#discussion_r1889618321 ## be/src/olap/rowset/beta_rowset.cpp: ## @@ -18,6 +18,7 @@ #include "olap/rowset/beta_rowset.h" #include +#include Review Comment: warning: inclu

Re: [PR] [fix](binlog) Avoid clear binlog dir [doris]

2024-12-17 Thread via GitHub
github-actions[bot] commented on PR #45581: URL: https://github.com/apache/doris/pull/45581#issuecomment-2550338443 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/12386638759";) output. shellcheck er

Re: [PR] [fix](binlog) Avoid clear binlog dir [doris]

2024-12-17 Thread via GitHub
hello-stephen commented on PR #45581: URL: https://github.com/apache/doris/pull/45581#issuecomment-2550337865 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro

[PR] [fix](binlog) Avoid clear binlog dir [doris]

2024-12-17 Thread via GitHub
w41ter opened a new pull request, #45581: URL: https://github.com/apache/doris/pull/45581 Fix the issue introduced by #45445 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #45445 Problem Summary: The binlog dir is shared with all r