Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-16 Thread via GitHub
eldenmoon merged PR #39307: URL: https://github.com/apache/doris/pull/39307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-16 Thread via GitHub
github-actions[bot] commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2292937971 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-16 Thread via GitHub
github-actions[bot] commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2292937934 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-15 Thread via GitHub
amorynan commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2292579394 run cloud_p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-15 Thread via GitHub
amorynan commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2290966164 run cloud_p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
amorynan commented on code in PR #39307: URL: https://github.com/apache/doris/pull/39307#discussion_r1718027368 ## be/src/vec/functions/array/function_array_aggregation.cpp: ## @@ -147,7 +147,13 @@ struct ArrayAggregateImpl { const DataTypeArray* data_type_array =

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
amorynan commented on code in PR #39307: URL: https://github.com/apache/doris/pull/39307#discussion_r1718027368 ## be/src/vec/functions/array/function_array_aggregation.cpp: ## @@ -147,7 +147,13 @@ struct ArrayAggregateImpl { const DataTypeArray* data_type_array =

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
amorynan commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2290759674 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2290507377 ClickBench: Total hot run time: 31.86 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2290500365 TPC-DS: Total hot run time: 184538 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2290484350 TPC-H: Total hot run time: 37246 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
eldenmoon commented on code in PR #39307: URL: https://github.com/apache/doris/pull/39307#discussion_r1717830824 ## be/src/vec/functions/array/function_array_aggregation.cpp: ## @@ -147,7 +147,13 @@ struct ArrayAggregateImpl { const DataTypeArray* data_type_array =

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
amorynan commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2290462704 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2290458453 TPC-H: Total hot run time: 37782 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
amorynan commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2290392295 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2288697889 ClickBench: Total hot run time: 31.04 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2288684090 TPC-DS: Total hot run time: 185524 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2288657658 TPC-H: Total hot run time: 37852 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-14 Thread via GitHub
amorynan commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2288603602 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2286150935 ClickBench: Total hot run time: 30.59 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2286139541 TPC-DS: Total hot run time: 185730 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2286111016 TPC-H: Total hot run time: 40291 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
github-actions[bot] commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2286088796 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
amorynan commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2286077074 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2285937792 ClickBench: Total hot run time: 30.45 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2285928781 TPC-DS: Total hot run time: 186502 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2285907155 TPC-H: Total hot run time: 39716 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
github-actions[bot] commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2285879823 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
github-actions[bot] commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2285878828 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
amorynan opened a new pull request, #39307: URL: https://github.com/apache/doris/pull/39307 ## Proposed changes in fe we will check the params same with be in be we throw exception if params is not support otherwise we will meet coredump like this ``` start BE in local mode

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
doris-robot commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2285866263 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](arrayfuncs) fix array min/max func [doris]

2024-08-13 Thread via GitHub
amorynan commented on PR #39307: URL: https://github.com/apache/doris/pull/39307#issuecomment-2285866631 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns