Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-27 Thread via GitHub
englefly merged PR #45237: URL: https://github.com/apache/doris/pull/45237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-27 Thread via GitHub
zclllyybb commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563508476 > return null 才是正确的返回方式 类比 除以0的情况 可能恰恰相反啊。。有些return null的,我们反而要逐渐改到报错去 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-27 Thread via GitHub
englefly commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563485714 return null 才是正确的返回方式 类比 除以0的情况 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-27 Thread via GitHub
github-actions[bot] commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563436581 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-27 Thread via GitHub
github-actions[bot] commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563436614 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563387403 ClickBench: Total hot run time: 30.85 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563383672 TPC-DS: Total hot run time: 191269 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563375802 TPC-H: Total hot run time: 32313 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
LiBinfeng-01 commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563362576 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563266381 ClickBench: Total hot run time: 31.4 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563263640 TPC-DS: Total hot run time: 196652 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563257811 TPC-H: Total hot run time: 32178 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
LiBinfeng-01 commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2563239217 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2562393062 ClickBench: Total hot run time: 31.39 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2562388021 TPC-DS: Total hot run time: 191352 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2562378012 TPC-H: Total hot run time: 32530 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
LiBinfeng-01 commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2562358230 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2562339504 ClickBench: Total hot run time: 31.77 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2562334881 TPC-DS: Total hot run time: 196450 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2562323791 TPC-H: Total hot run time: 32789 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-26 Thread via GitHub
LiBinfeng-01 commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2562291451 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-25 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2562140817 ClickBench: Total hot run time: 31.55 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-25 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2562138716 TPC-DS: Total hot run time: 190717 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-25 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-256214 TPC-H: Total hot run time: 32426 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-25 Thread via GitHub
LiBinfeng-01 commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2562119990 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-25 Thread via GitHub
LiBinfeng-01 commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2561829631 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-18 Thread via GitHub
HappenLee commented on code in PR #45237: URL: https://github.com/apache/doris/pull/45237#discussion_r1889813551 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DateTimeLiteral.java: ## @@ -395,9 +396,10 @@ public LocalDateTime toJavaDateType() {

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-10 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2531064903 ClickBench: Total hot run time: 32.5 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-10 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2531051958 TPC-DS: Total hot run time: 197339 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-10 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2531021639 TPC-H: Total hot run time: 40205 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-10 Thread via GitHub
LiBinfeng-01 commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2530790111 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-10 Thread via GitHub
doris-robot commented on PR #45237: URL: https://github.com/apache/doris/pull/45237#issuecomment-2530788271 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+proce

[PR] [fix](Nereids) fix fe fold constant with date time out of range [doris]

2024-12-10 Thread via GitHub
LiBinfeng-01 opened a new pull request, #45237: URL: https://github.com/apache/doris/pull/45237 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: When running sql: select date_add('-12-31 23:59:59', interval 5 se