github-actions[bot] commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2785114676
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2785114649
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
morrySnow commented on code in PR #49048:
URL: https://github.com/apache/doris/pull/49048#discussion_r2034393372
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Printf.java:
##
@@ -0,0 +1,82 @@
+// Licensed to the Apache Software Foundatio
morrySnow commented on code in PR #49048:
URL: https://github.com/apache/doris/pull/49048#discussion_r2034392539
##
regression-test/suites/query_p0/sql_functions/string_functions/test_printf.groovy:
##
@@ -0,0 +1,171 @@
+// Licensed to the Apache Software Foundation (ASF) under
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2781540324
# BE UT Coverage Report
Increment line coverage `84.95% (79/93)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/80ae3ffc3b411a2420f148b068cd73560f
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2781501777
ClickBench: Total hot run time: 31.49 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2781499737
TPC-DS: Total hot run time: 192267 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2781495219
TPC-H: Total hot run time: 34250 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
suxiaogang223 commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2781479346
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
suxiaogang223 commented on code in PR #49048:
URL: https://github.com/apache/doris/pull/49048#discussion_r2024150760
##
regression-test/suites/query_p0/sql_functions/string_functions/test_printf.groovy:
##
@@ -0,0 +1,171 @@
+// Licensed to the Apache Software Foundation (ASF) un
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2771922006
TPC-DS: Total hot run time: 185952 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
suxiaogang223 commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2774399345
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zclllyybb commented on code in PR #49048:
URL: https://github.com/apache/doris/pull/49048#discussion_r2016594878
##
regression-test/suites/query_p0/sql_functions/string_functions/test_printf.groovy:
##
Review Comment:
没实现常量折叠的就不用check_fold_consistency了。用普通qt_sql覆盖下。
测试一下
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2774524476
TPC-DS: Total hot run time: 186512 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2774696770
ClickBench: Total hot run time: 31.55 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2774686061
TPC-DS: Total hot run time: 193186 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2774663478
TPC-H: Total hot run time: 34177 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
morningman commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2774639149
> Why do we need this function? What if lib fmt is upgraded, can we keep
behavior consistent?
Compare to hive `printf`.
I think the test cases can help us to guarantee that
suxiaogang223 commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2774601480
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zhiqiang- commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2774620197
Why do we need this function? What if lib fmt is upgraded, can we keep
behavior consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message,
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2774530202
ClickBench: Total hot run time: 31.47 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2774509462
TPC-H: Total hot run time: 33981 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
suxiaogang223 commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2774398456
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
suxiaogang223 commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2772742703
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2772207800
# BE UT Coverage Report
Increment line coverage `84.95% (79/93)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/6feb957cc75db7d3c50a89c3694c5cc18b
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2771936980
ClickBench: Total hot run time: 31.27 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
suxiaogang223 commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2771813817
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2771885954
TPC-H: Total hot run time: 34335 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
suxiaogang223 commented on code in PR #49048:
URL: https://github.com/apache/doris/pull/49048#discussion_r2024152983
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Printf.java:
##
@@ -0,0 +1,82 @@
+// Licensed to the Apache Software Found
morrySnow commented on code in PR #49048:
URL: https://github.com/apache/doris/pull/49048#discussion_r2022203768
##
regression-test/suites/query_p0/sql_functions/string_functions/test_printf.groovy:
##
@@ -0,0 +1,171 @@
+// Licensed to the Apache Software Foundation (ASF) under
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2760240512
# BE UT Coverage Report
Increment line coverage `84.95% (79/93)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/47c9517a422178b2044e79ac4f33e87fbf
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2760129979
TPC-DS: Total hot run time: 193304 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2760135453
ClickBench: Total hot run time: 31.39 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2760118404
TPC-H: Total hot run time: 34168 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
suxiaogang223 commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2760079209
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
suxiaogang223 commented on code in PR #49048:
URL: https://github.com/apache/doris/pull/49048#discussion_r2016665138
##
regression-test/suites/query_p0/sql_functions/string_functions/test_printf.groovy:
##
Review Comment:
copy that，对xpath_string也应该做一样的改动
--
This is an a
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2757796111
# BE UT Coverage Report
Increment line coverage `84.62% (66/78)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/da3c4f5eaeac2f43fc58be22efa38c8e41
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2757471611
TPC-DS: Total hot run time: 192985 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2757485739
ClickBench: Total hot run time: 31.28 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2757430628
TPC-H: Total hot run time: 34197 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
suxiaogang223 commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2757295842
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
Thearas commented on PR #49048:
URL: https://github.com/apache/doris/pull/49048#issuecomment-2721237947
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
suxiaogang223 opened a new pull request, #49048:
URL: https://github.com/apache/doris/pull/49048
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
-
43 matches
Mail list logo
