zhangstar333 merged PR #33055:
URL: https://github.com/apache/doris/pull/33055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2045089324
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2042555914
TeamCity be ut coverage result:
Function Coverage: 35.59% (8889/24977)
Line Coverage: 27.34% (73000/267030)
Region Coverage: 26.50% (37721/142352)
Branch Coverage: 23.3
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2042489124
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wyxxxcat commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2042477065
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2042475132
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HappenLee commented on code in PR #33055:
URL: https://github.com/apache/doris/pull/33055#discussion_r1554801889
##
be/src/vec/functions/function_string.cpp:
##
@@ -57,6 +57,28 @@ struct StringASCII {
}
};
+struct NameQuote {
+static constexpr auto name = "quote";
+}
HappenLee commented on code in PR #33055:
URL: https://github.com/apache/doris/pull/33055#discussion_r1554801961
##
be/src/vec/functions/function_string.cpp:
##
@@ -57,6 +57,28 @@ struct StringASCII {
}
};
+struct NameQuote {
+static constexpr auto name = "quote";
+}
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2036819264
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
doris-robot commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2034367690
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit f137d289867ec3a6dcf138385b1d5b1cac894661 with
default session variables
Stream
doris-robot commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2034362012
ClickBench: Total hot run time: 30.32 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2034347525
TPC-DS: Total hot run time: 179874 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2034323398
TeamCity be ut coverage result:
Function Coverage: 35.65% (8883/24916)
Line Coverage: 27.38% (72918/266366)
Region Coverage: 26.54% (37698/142019)
Branch Coverage: 23.3
doris-robot commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2034322344
TPC-H: Total hot run time: 39602 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2034263804
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2034253956
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2034252359
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wyxxxcat commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2034249905
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2033831117
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on code in PR #33055:
URL: https://github.com/apache/doris/pull/33055#discussion_r1548817965
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Quote.java:
##
@@ -0,0 +1,69 @@
+// Licensed to the Apache Software Foundation
zclllyybb commented on code in PR #33055:
URL: https://github.com/apache/doris/pull/33055#discussion_r1548817616
##
regression-test/suites/nereids_function_p0/scalar_function/Q.groovy:
##
Review Comment:
delete your change since you have be-ut already
--
This is an auto
zclllyybb commented on code in PR #33055:
URL: https://github.com/apache/doris/pull/33055#discussion_r1548817415
##
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java:
##
@@ -888,11 +890,11 @@ public class BuiltinScalarFunctions implements
FunctionHel
zclllyybb commented on code in PR #33055:
URL: https://github.com/apache/doris/pull/33055#discussion_r1548816174
##
be/test/vec/function/function_string_test.cpp:
##
@@ -214,6 +214,17 @@ TEST(function_string_test, function_string_length_test) {
static_cast(check_function(fu
zclllyybb commented on code in PR #33055:
URL: https://github.com/apache/doris/pull/33055#discussion_r1548816392
##
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java:
##
@@ -888,11 +890,11 @@ public class BuiltinScalarFunctions implements
FunctionHel
zclllyybb commented on code in PR #33055:
URL: https://github.com/apache/doris/pull/33055#discussion_r1548815822
##
be/src/vec/functions/function_string.cpp:
##
@@ -57,6 +57,25 @@ struct StringASCII {
}
};
+struct NameQuote {
+static constexpr auto name = "quote";
+}
doris-robot commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2032573918
TPC-H: Total hot run time: 38724 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2032574656
TeamCity be ut coverage result:
Function Coverage: 35.64% (8882/24921)
Line Coverage: 27.37% (72924/266412)
Region Coverage: 26.54% (37706/142051)
Branch Coverage: 23.3
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2032523084
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wyxxxcat commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2032512270
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2032462621
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wyxxxcat commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2032456167
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2032446625
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
doris-robot commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2030219012
TeamCity be ut coverage result:
Function Coverage: 35.55% (8843/24874)
Line Coverage: 27.30% (72583/265892)
Region Coverage: 26.48% (37540/141765)
Branch Coverage: 23.2
wyxxxcat commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2030109432
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2030105843
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2027862685
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on code in PR #33055:
URL: https://github.com/apache/doris/pull/33055#discussion_r1544862502
##
regression-test/data/nereids_function_p0/scalar_function/Q.out:
##
@@ -86,3 +86,135 @@
1
1
+-- !sql_quote_varchar_notenull --
+'varchar11'
+'varchar11'
+'varch
zclllyybb commented on code in PR #33055:
URL: https://github.com/apache/doris/pull/33055#discussion_r1544861742
##
regression-test/suites/nereids_function_p0/scalar_function/Q.groovy:
##
@@ -25,4 +25,13 @@ suite("nereids_scalar_fn_Q") {
qt_sql_quarter_DateTimeV2_notnull
zclllyybb commented on code in PR #33055:
URL: https://github.com/apache/doris/pull/33055#discussion_r1544860848
##
be/src/vec/functions/function_string.cpp:
##
@@ -57,6 +62,72 @@ struct StringASCII {
}
};
+struct NameQuote {
+static constexpr auto name = "quote";
+}
doris-robot commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2027318638
TeamCity be ut coverage result:
Function Coverage: 35.55% (8840/24865)
Line Coverage: 27.29% (72493/265685)
Region Coverage: 26.50% (37523/141574)
Branch Coverage: 23.3
wyxxxcat commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2027292475
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2027292901
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
doris-robot commented on PR #33055:
URL: https://github.com/apache/doris/pull/33055#issuecomment-2027286819
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
wyxxxcat opened a new pull request, #33055:
URL: https://github.com/apache/doris/pull/33055
## Proposed changes
Issue Number: #xxx
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d...@
44 matches
Mail list logo
