Re: [PR] [feature](function) support bitmap type in min/max_by agg function [doris]

2023-10-16 Thread via GitHub
wm1581066 commented on PR #25430: URL: https://github.com/apache/doris/pull/25430#issuecomment-1765654056 TT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] [feature](function) support bitmap type in min/max_by agg function [doris]

2023-10-15 Thread via GitHub
yiguolei merged PR #25430: URL: https://github.com/apache/doris/pull/25430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [feature](function) support bitmap type in min/max_by agg function [doris]

2023-10-15 Thread via GitHub
github-actions[bot] commented on PR #25430: URL: https://github.com/apache/doris/pull/25430#issuecomment-1763650762 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature](function) support bitmap type in min/max_by agg function [doris]

2023-10-15 Thread via GitHub
github-actions[bot] commented on PR #25430: URL: https://github.com/apache/doris/pull/25430#issuecomment-1763650730 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](function) support bitmap type in min/max_by agg function [doris]

2023-10-13 Thread via GitHub
doris-robot commented on PR #25430: URL: https://github.com/apache/doris/pull/25430#issuecomment-1761330302 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.45 seconds stream load tsv: 574 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](function) support bitmap type in min/max_by agg function [doris]

2023-10-13 Thread via GitHub
doris-robot commented on PR #25430: URL: https://github.com/apache/doris/pull/25430#issuecomment-1761306429 TeamCity be ut coverage result: Function Coverage: 36.27% (8146/22459) Line Coverage: 28.50% (65310/229133) Region Coverage: 27.19% (33832/124424) Branch Coverage: 23.9

Re: [PR] [feature](function) support bitmap type in min/max_by agg function [doris]

2023-10-13 Thread via GitHub
github-actions[bot] commented on code in PR #25430: URL: https://github.com/apache/doris/pull/25430#discussion_r1358081152 ## be/src/vec/aggregate_functions/aggregate_function_min_max_by.h: ## @@ -18,15 +18,70 @@ #pragma once #include "common/logging.h" +#include "util/bitma

Re: [PR] [feature](function) support bitmap type in min/max_by agg function [doris]

2023-10-13 Thread via GitHub
github-actions[bot] commented on PR #25430: URL: https://github.com/apache/doris/pull/25430#issuecomment-1761280629 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature](function) support bitmap type in min/max_by agg function [doris]

2023-10-13 Thread via GitHub
zhangstar333 commented on PR #25430: URL: https://github.com/apache/doris/pull/25430#issuecomment-1761272907 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [feature](function) support bitmap type in min/max_by agg function [doris]

2023-10-13 Thread via GitHub
zhangstar333 opened a new pull request, #25430: URL: https://github.com/apache/doris/pull/25430 ## Proposed changes support bitmap type in min/max_by agg function Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick